From: Christoph Fritz <chf.fritz@googlemail.com>
To: David Miller <davem@davemloft.net>
Cc: steve.glendinning@shawell.net, netdev@vger.kernel.org
Subject: Re: usbnet: smsc95xx: fix link detection for disabled autonegotiation
Date: Mon, 30 May 2016 22:07:42 +0200 [thread overview]
Message-ID: <1464638862.1883.31.camel@googlemail.com> (raw)
In-Reply-To: <20160529.223010.1702681088925445499.davem@davemloft.net>
On Sun, 2016-05-29 at 22:30 -0700, David Miller wrote:
> From: Christoph Fritz <chf.fritz@googlemail.com>
> Date: Thu, 26 May 2016 04:06:47 +0200
>
> > @@ -1695,6 +1745,7 @@ static int smsc95xx_resume(struct usb_interface *intf)
> >
> > /* do this first to ensure it's cleared even in error case */
> > pdata->suspend_flags = 0;
> > + schedule_delayed_work(&pdata->carrier_check, CARRIER_CHECK_DELAY);
>
> Why are you not cancelling this delayed work in the suspend routine of
> the driver?
I'm doing this:
+ if (pdata->suspend_flags != 0)
+ return;
inside the "worker-function" so that schedule_delayed_work() is not
called again.
Should I explicitly cancel_delayed_work() inside suspend() too?
next prev parent reply other threads:[~2016-05-30 20:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 2:06 usbnet: smsc95xx: fix link detection for disabled autonegotiation Christoph Fritz
2016-05-26 2:31 ` Andrew Lunn
2016-05-26 11:01 ` Christoph Fritz
2016-05-26 18:21 ` Florian Fainelli
2016-05-30 5:30 ` David Miller
2016-05-30 20:07 ` Christoph Fritz [this message]
2016-05-31 21:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464638862.1883.31.camel@googlemail.com \
--to=chf.fritz@googlemail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).