From: Kangjie Lu <kangjielu@gmail.com>
To: santosh.shilimkar@oracle.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, taesoo@gatech.edu,
csong84@gatech.edu, Kangjie Lu <kjlu@gatech.edu>
Subject: [PATCH] rds: fix an infoleak in rds_inc_info_copy
Date: Thu, 2 Jun 2016 04:11:20 -0400 [thread overview]
Message-ID: <1464855080-29671-1-git-send-email-kjlu@gatech.edu> (raw)
The last field "flags" of object "minfo" is not initialized.
Copying this object out may leak kernel stack data.
Assign 0 to it to avoid leak.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
---
net/rds/recv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/rds/recv.c b/net/rds/recv.c
index c0be1ec..8413f6c 100644
--- a/net/rds/recv.c
+++ b/net/rds/recv.c
@@ -561,5 +561,7 @@ void rds_inc_info_copy(struct rds_incoming *inc,
minfo.fport = inc->i_hdr.h_dport;
}
+ minfo.flags = 0;
+
rds_info_copy(iter, &minfo, sizeof(minfo));
}
--
2.7.4
next reply other threads:[~2016-06-02 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 8:11 Kangjie Lu [this message]
2016-06-02 15:25 ` [PATCH] rds: fix an infoleak in rds_inc_info_copy Santosh Shilimkar
2016-06-03 4:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464855080-29671-1-git-send-email-kjlu@gatech.edu \
--to=kangjielu@gmail.com \
--cc=csong84@gatech.edu \
--cc=davem@davemloft.net \
--cc=kjlu@gatech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh.shilimkar@oracle.com \
--cc=taesoo@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).