From: John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
To: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: Sean Wang <keyhaede-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>,
Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>
Subject: [PATCH 07/12] net: mediatek: disable all interrupts during probe
Date: Sun, 5 Jun 2016 08:33:00 +0200 [thread overview]
Message-ID: <1465108385-38286-8-git-send-email-john@phrozen.org> (raw)
In-Reply-To: <1465108385-38286-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
The current code only disables those IRQs that we will later use. To
ensure that we have a predefined state, we really want to disable all IRQs.
Change the code to disable all IRQs to achieve this.
Signed-off-by: John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index bfac376..93af4e3 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1375,7 +1375,7 @@ static int __init mtk_hw_init(struct mtk_eth *eth)
/* disable delay and normal interrupt */
mtk_w32(eth, 0, MTK_QDMA_DELAY_INT);
- mtk_irq_disable(eth, MTK_TX_DONE_INT | MTK_RX_DONE_INT);
+ mtk_irq_disable(eth, ~0);
mtk_w32(eth, RST_GL_PSE, MTK_RST_GL);
mtk_w32(eth, 0, MTK_RST_GL);
--
1.7.10.4
next prev parent reply other threads:[~2016-06-05 6:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 6:32 [PATCH 00/12] net: mediatek: various small fixes John Crispin
2016-06-05 6:32 ` [PATCH 03/12] net: mediatek: fix missing free of scratch memory John Crispin
[not found] ` <1465108385-38286-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2016-06-05 6:32 ` [PATCH 01/12] net: mediatek: fix DQL support John Crispin
2016-06-05 7:32 ` David Miller
2016-06-06 6:43 ` John Crispin
2016-06-07 23:01 ` David Miller
2016-06-07 23:20 ` Tom Herbert
2016-06-05 6:32 ` [PATCH 02/12] net: mediatek: add missing return code check John Crispin
2016-06-05 6:32 ` [PATCH 04/12] net: mediatek: invalid buffer lookup in mtk_tx_map() John Crispin
2016-06-05 6:32 ` [PATCH 05/12] net: mediatek: dropped rx packets are not being counted properly John Crispin
2016-06-05 6:32 ` [PATCH 06/12] net: mediatek: add next data pointer coherency protection John Crispin
2016-06-05 6:33 ` John Crispin [this message]
2016-06-05 6:33 ` [PATCH 08/12] net: mediatek: fix threshold value John Crispin
2016-06-05 6:33 ` [PATCH 09/12] net: mediatek: increase watchdog_timeo John Crispin
2016-06-05 14:56 ` Andrew Lunn
2016-06-06 6:24 ` John Crispin
2016-06-06 12:21 ` Andrew Lunn
2016-06-06 12:38 ` John Crispin
2016-06-05 6:33 ` [PATCH 10/12] net: mediatek: fix off by one in the TX ring allocation John Crispin
2016-06-05 6:33 ` [PATCH 11/12] net: mediatek: only wake the queue if it is stopped John Crispin
2016-06-05 6:33 ` [PATCH 12/12] net: mediatek: remove superfluous queue wake up call John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465108385-38286-8-git-send-email-john@phrozen.org \
--to=john-pj+rj9u5fofafugrpc6u6w@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=keyhaede-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=nbd-Vt+b4OUoWG0@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).