netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: [PATCH net-next 0/2] net: sched: faster stats gathering
Date: Mon,  6 Jun 2016 09:37:14 -0700	[thread overview]
Message-ID: <1465231036-10674-1-git-send-email-edumazet@google.com> (raw)

A while back, I sent one RFC patch using lockless stats gathering
on 64bit arches.

This patch series does it more cleanly, using a seqcount.

Since qdisc/class stats are written at dequeue() time,
we can ask the dequeue to change the seqcount, so that
stats readers can avoid taking the root qdisc lock,
and instead the typical read_seqcount_{begin|retry} guarded
loop.

This does not change fast path costs, as the seqcount
increments are not more expensive than the bit manipulation,
and allows readers to not freeze the fast path anymore.

Eric Dumazet (2):
  net_sched: transform qdisc running bit into a seqcount
  net: sched: do not acquire qdisc spinlock in qdisc/class stats dump

 Documentation/networking/gen_stats.txt |  2 +-
 drivers/net/bonding/bond_main.c        |  2 ++
 drivers/net/ppp/ppp_generic.c          |  3 +++
 drivers/net/team/team.c                |  2 ++
 include/linux/netdevice.h              |  1 +
 include/net/gen_stats.h                | 12 ++++++++----
 include/net/sch_generic.h              | 23 ++++++++++++-----------
 net/bluetooth/6lowpan.c                |  2 ++
 net/core/dev.c                         |  2 +-
 net/core/gen_estimator.c               | 24 ++++++++++++++++--------
 net/core/gen_stats.c                   | 34 +++++++++++++++++++++++-----------
 net/ieee802154/6lowpan/core.c          |  3 +++
 net/l2tp/l2tp_eth.c                    |  4 ++++
 net/netfilter/xt_RATEEST.c             |  2 +-
 net/sched/act_api.c                    |  4 ++--
 net/sched/act_police.c                 |  3 ++-
 net/sched/sch_api.c                    | 21 +++++++++++----------
 net/sched/sch_atm.c                    |  3 ++-
 net/sched/sch_cbq.c                    |  9 ++++++---
 net/sched/sch_drr.c                    |  9 ++++++---
 net/sched/sch_fq_codel.c               | 15 +++++++++++----
 net/sched/sch_generic.c                | 14 ++++++++++----
 net/sched/sch_hfsc.c                   | 10 +++++-----
 net/sched/sch_htb.c                    | 11 ++++++-----
 net/sched/sch_mq.c                     |  2 +-
 net/sched/sch_mqprio.c                 | 11 +++++++----
 net/sched/sch_multiq.c                 |  3 ++-
 net/sched/sch_prio.c                   |  3 ++-
 net/sched/sch_qfq.c                    |  9 ++++++---
 29 files changed, 158 insertions(+), 85 deletions(-)

-- 
2.8.0.rc3.226.g39d4020

             reply	other threads:[~2016-06-06 16:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 16:37 Eric Dumazet [this message]
2016-06-06 16:37 ` [PATCH net-next 1/2] net_sched: transform qdisc running bit into a seqcount Eric Dumazet
2016-06-06 16:37 ` [PATCH net-next 2/2] net: sched: do not acquire qdisc spinlock in qdisc/class stats dump Eric Dumazet
2016-06-06 23:15   ` Cong Wang
2016-06-06 23:53     ` Eric Dumazet
2016-06-07 23:39       ` Cong Wang
2016-06-07 23:37 ` [PATCH net-next 0/2] net: sched: faster stats gathering David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465231036-10674-1-git-send-email-edumazet@google.com \
    --to=edumazet@google.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).