* [PATCH] net-sysfs: fix missing <linux/of_net.h>
@ 2016-06-07 18:27 Ben Dooks
2016-06-08 7:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2016-06-07 18:27 UTC (permalink / raw)
To: linux-kernel; +Cc: Ben Dooks, David S. Miller, netdev
The of_find_net_device_by_node() function is defined in
<linux/of_net.h> but not included in the .c file that
implements it. Fix the following warning by including the
header:
net/core/net-sysfs.c:1494:19: warning: symbol 'of_find_net_device_by_node' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
---
net/core/net-sysfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 2b3f76f..7a0b616 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -24,6 +24,7 @@
#include <linux/jiffies.h>
#include <linux/pm_runtime.h>
#include <linux/of.h>
+#include <linux/of_net.h>
#include "net-sysfs.h"
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net-sysfs: fix missing <linux/of_net.h>
2016-06-07 18:27 [PATCH] net-sysfs: fix missing <linux/of_net.h> Ben Dooks
@ 2016-06-08 7:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-06-08 7:38 UTC (permalink / raw)
To: ben.dooks; +Cc: linux-kernel, netdev
From: Ben Dooks <ben.dooks@codethink.co.uk>
Date: Tue, 7 Jun 2016 19:27:51 +0100
> The of_find_net_device_by_node() function is defined in
> <linux/of_net.h> but not included in the .c file that
> implements it. Fix the following warning by including the
> header:
>
> net/core/net-sysfs.c:1494:19: warning: symbol 'of_find_net_device_by_node' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-08 7:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-07 18:27 [PATCH] net-sysfs: fix missing <linux/of_net.h> Ben Dooks
2016-06-08 7:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).