From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Philip Prindeville <philipp@redfish-solutions.com>,
netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads
Date: Tue, 07 Jun 2016 22:23:42 +0200 [thread overview]
Message-ID: <1465331022.134529.630880921.787BED73@webmail.messagingengine.com> (raw)
In-Reply-To: <20160607194846.11494-1-philipp@redfish-solutions.com>
On Tue, Jun 7, 2016, at 21:48, Philip Prindeville wrote:
> static struct rtnl_link_ops ipgre_link_ops __read_mostly = {
> diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
> index d8f5e0a..95649eb 100644
> --- a/net/ipv4/ip_tunnel.c
> +++ b/net/ipv4/ip_tunnel.c
> @@ -682,7 +682,7 @@ void ip_tunnel_xmit(struct sk_buff *skb, struct
> net_device *dev,
> }
>
> df = tnl_params->frag_off;
> - if (skb->protocol == htons(ETH_P_IP))
> + if (skb->protocol == htons(ETH_P_IP) && !tunnel->ignore_df)
> df |= (inner_iph->frag_off&htons(IP_DF));
>
> max_headroom = LL_RESERVED_SPACE(rt->dst.dev) + sizeof(struct iphdr)
Is still enforce that we inherit the ttl from the inner header to the
outer header if we don't set df bit?
Thanks,
Hannes
next prev parent reply other threads:[~2016-06-07 20:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 19:48 [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads Philip Prindeville
2016-06-07 20:23 ` Hannes Frederic Sowa [this message]
2016-06-07 20:42 ` Philip Prindeville
2016-06-07 22:23 ` Hannes Frederic Sowa
2016-06-07 22:28 ` Philip Prindeville
2016-06-08 3:22 ` Alexander Duyck
2016-06-08 3:28 ` Philip Prindeville
2016-06-11 6:02 ` David Miller
2016-06-13 18:59 ` Philip Prindeville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465331022.134529.630880921.787BED73@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=philipp@redfish-solutions.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).