netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, andrew@lunn.ch,
	vivien.didelot@savoirfairelinux.com,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH net-next v3 1/6] net: dsa: Provide unique DSA slave MII bus names
Date: Tue,  7 Jun 2016 14:06:51 -0700	[thread overview]
Message-ID: <1465333616-6351-2-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1465333616-6351-1-git-send-email-f.fainelli@gmail.com>

In case we have multiples trees and switches with the same index, we
need to add another discriminating id: the switch tree.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 net/dsa/slave.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 15a492261895..a51dfedf0014 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -49,7 +49,8 @@ void dsa_slave_mii_bus_init(struct dsa_switch *ds)
 	ds->slave_mii_bus->name = "dsa slave smi";
 	ds->slave_mii_bus->read = dsa_slave_phy_read;
 	ds->slave_mii_bus->write = dsa_slave_phy_write;
-	snprintf(ds->slave_mii_bus->id, MII_BUS_ID_SIZE, "dsa-%d", ds->index);
+	snprintf(ds->slave_mii_bus->id, MII_BUS_ID_SIZE, "dsa-%d.%d",
+		 ds->dst->tree, ds->index);
 	ds->slave_mii_bus->parent = ds->dev;
 	ds->slave_mii_bus->phy_mask = ~ds->phys_mii_mask;
 }
-- 
2.7.4

  reply	other threads:[~2016-06-07 21:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 21:06 [PATCH net-next v3 0/6] net: dsa: misc improvements Florian Fainelli
2016-06-07 21:06 ` Florian Fainelli [this message]
2016-06-07 21:06 ` [PATCH net-next v3 2/6] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask Florian Fainelli
2016-06-07 21:32   ` Andrew Lunn
2016-06-07 21:06 ` [PATCH net-next v3 3/6] net: dsa: Provide a slave MII bus if needed Florian Fainelli
2016-06-07 21:40   ` Andrew Lunn
2016-06-07 22:52   ` Vivien Didelot
2016-06-07 21:06 ` [PATCH net-next v3 4/6] net: dsa: Add initialization helper for CPU port ethtool_ops Florian Fainelli
2016-06-07 22:54   ` Vivien Didelot
2016-06-07 21:06 ` [PATCH net-next v3 5/6] net: dsa: Initialize CPU port ethtool ops per tree Florian Fainelli
2016-06-07 21:51   ` Andrew Lunn
2016-06-07 22:13     ` Florian Fainelli
2016-06-07 22:24       ` Andrew Lunn
2016-06-07 21:06 ` [PATCH net-next v3 6/6] net: dsa: bcm_sf2: Register our slave MDIO bus Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465333616-6351-2-git-send-email-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).