From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: [PATCHv3 net 1/3] net: cls_u32: fix error code for invalid flags Date: Tue, 7 Jun 2016 23:17:01 +0100 Message-ID: <1465337823-16096-2-git-send-email-jakub.kicinski@netronome.com> References: <1465226208-32097-1-git-send-email-jakub.kicinski@netronome.com> <1465337823-16096-1-git-send-email-jakub.kicinski@netronome.com> Cc: john.r.fastabend@intel.com, sridhar.samudrala@intel.com, Jakub Kicinski To: netdev@vger.kernel.org Return-path: Received: from mail-wm0-f52.google.com ([74.125.82.52]:37442 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756703AbcFGWRO (ORCPT ); Tue, 7 Jun 2016 18:17:14 -0400 Received: by mail-wm0-f52.google.com with SMTP id k204so87631929wmk.0 for ; Tue, 07 Jun 2016 15:17:13 -0700 (PDT) In-Reply-To: <1465337823-16096-1-git-send-email-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: 'err' variable is not set in this test, we would return whatever previous test set 'err' to. Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena Reviewed-by: Simon Horman Acked-by: Sridhar Samudrala Acked-by: John Fastabend --- net/sched/cls_u32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 079b43b3c5d2..b17e090f2fe1 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -863,7 +863,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, if (tb[TCA_U32_FLAGS]) { flags = nla_get_u32(tb[TCA_U32_FLAGS]); if (!tc_flags_valid(flags)) - return err; + return -EINVAL; } n = (struct tc_u_knode *)*arg; -- 1.9.1