netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: netdev@vger.kernel.org
Cc: john.r.fastabend@intel.com, sridhar.samudrala@intel.com,
	Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [PATCHv3 net 3/3] net: cls_u32: catch all hardware offload errors
Date: Tue,  7 Jun 2016 23:17:03 +0100	[thread overview]
Message-ID: <1465337823-16096-4-git-send-email-jakub.kicinski@netronome.com> (raw)
In-Reply-To: <1465337823-16096-1-git-send-email-jakub.kicinski@netronome.com>

Errors reported by u32_replace_hw_hnode() were not propagated.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dinan Gunawardena <dgunawardena@netronome.com>
---
v3:
 - new patch

 net/sched/cls_u32.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index 0fc1d47885f8..b9c3875fddc6 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -923,11 +923,17 @@ static int u32_change(struct net *net, struct sk_buff *in_skb,
 		ht->divisor = divisor;
 		ht->handle = handle;
 		ht->prio = tp->prio;
+
+		err = u32_replace_hw_hnode(tp, ht, flags);
+		if (err) {
+			kfree(ht);
+			return err;
+		}
+
 		RCU_INIT_POINTER(ht->next, tp_c->hlist);
 		rcu_assign_pointer(tp_c->hlist, ht);
 		*arg = (unsigned long)ht;
 
-		u32_replace_hw_hnode(tp, ht, flags);
 		return 0;
 	}
 
-- 
1.9.1

  parent reply	other threads:[~2016-06-07 22:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 15:16 [PATCH net 0/2] cls_u32 hardware offload fixes Jakub Kicinski
2016-06-06 15:16 ` [PATCH net 1/2] net: cls_u32: fix error code for invalid flags Jakub Kicinski
2016-06-06 17:16   ` Samudrala, Sridhar
2016-06-07 15:46   ` John Fastabend
2016-06-06 15:16 ` [PATCH net 2/2] net: cls_u32: be more strict about skip-sw flag Jakub Kicinski
2016-06-06 17:25   ` Samudrala, Sridhar
2016-06-07 10:46 ` [PATCHv2 net 0/2] cls_u32 hardware offload fixes Jakub Kicinski
2016-06-07 10:46   ` [PATCHv2 net 1/2] net: cls_u32: fix error code for invalid flags Jakub Kicinski
2016-06-07 15:47     ` John Fastabend
2016-06-07 10:46   ` [PATCHv2 net 2/2] net: cls_u32: be more strict about skip-sw flag Jakub Kicinski
2016-06-07 15:53     ` John Fastabend
2016-06-07 16:06       ` Jakub Kicinski
2016-06-07 22:17 ` [PATCHv3 net 0/3] cls_u32 hardware offload fixes Jakub Kicinski
2016-06-07 22:17   ` [PATCHv3 net 1/3] net: cls_u32: fix error code for invalid flags Jakub Kicinski
2016-06-07 22:17   ` [PATCHv3 net 2/3] net: cls_u32: be more strict about skip-sw flag Jakub Kicinski
2016-06-07 22:36     ` Samudrala, Sridhar
2016-06-07 22:17   ` Jakub Kicinski [this message]
2016-06-07 22:38     ` [PATCHv3 net 3/3] net: cls_u32: catch all hardware offload errors Samudrala, Sridhar
2016-06-07 23:27 ` [PATCH net 0/2] cls_u32 hardware offload fixes David Miller
2016-06-08 10:18   ` Jakub Kicinski
2016-06-08 18:09     ` David Miller
2016-06-08 19:18       ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465337823-16096-4-git-send-email-jakub.kicinski@netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=john.r.fastabend@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sridhar.samudrala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).