From: Stefan Wahren <stefan.wahren@i2se.com>
To: David Miller <davem@davemloft.net>, Fugang Duan <fugang.duan@nxp.com>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>, <andrew@lunn.ch>,
<holgerschurig@gmail.com>,
Troy Kisky <troy.kisky@boundarydevices.com>,
<linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
Stefan Wahren <stefan.wahren@i2se.com>
Subject: [PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely
Date: Wed, 8 Jun 2016 20:42:46 +0000 [thread overview]
Message-ID: <1465418567-2694-1-git-send-email-stefan.wahren@i2se.com> (raw)
Since msleep is based on jiffies the PHY reset could take longer
than expected. So use msleep for values greater than 20 msec otherwise
usleep_range.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/net/ethernet/freescale/fec_main.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 3c0255e..49f8055 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3191,7 +3191,12 @@ static void fec_reset_phy(struct platform_device *pdev)
dev_err(&pdev->dev, "failed to get phy-reset-gpios: %d\n", err);
return;
}
- msleep(msec);
+
+ if (msec > 20)
+ msleep(msec);
+ else
+ usleep_range(msec * 1000, msec * 1000 + 1000);
+
gpio_set_value_cansleep(phy_reset, !active_high);
}
#else /* CONFIG_OF */
--
1.7.9.5
next reply other threads:[~2016-06-08 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 20:42 Stefan Wahren [this message]
2016-06-12 5:16 ` [PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely Fugang Duan
2016-06-13 1:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465418567-2694-1-git-send-email-stefan.wahren@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=fabio.estevam@nxp.com \
--cc=fugang.duan@nxp.com \
--cc=holgerschurig@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).