* [PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely
@ 2016-06-08 20:42 Stefan Wahren
2016-06-12 5:16 ` Fugang Duan
2016-06-13 1:58 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Wahren @ 2016-06-08 20:42 UTC (permalink / raw)
To: David Miller, Fugang Duan
Cc: Fabio Estevam, Lucas Stach, andrew, holgerschurig, Troy Kisky,
linux-arm-kernel, netdev, Stefan Wahren
Since msleep is based on jiffies the PHY reset could take longer
than expected. So use msleep for values greater than 20 msec otherwise
usleep_range.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/net/ethernet/freescale/fec_main.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 3c0255e..49f8055 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3191,7 +3191,12 @@ static void fec_reset_phy(struct platform_device *pdev)
dev_err(&pdev->dev, "failed to get phy-reset-gpios: %d\n", err);
return;
}
- msleep(msec);
+
+ if (msec > 20)
+ msleep(msec);
+ else
+ usleep_range(msec * 1000, msec * 1000 + 1000);
+
gpio_set_value_cansleep(phy_reset, !active_high);
}
#else /* CONFIG_OF */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely
2016-06-08 20:42 [PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely Stefan Wahren
@ 2016-06-12 5:16 ` Fugang Duan
2016-06-13 1:58 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Fugang Duan @ 2016-06-12 5:16 UTC (permalink / raw)
To: Stefan Wahren, David Miller
Cc: Fabio Estevam, Lucas Stach, andrew@lunn.ch,
holgerschurig@gmail.com, Troy Kisky,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
From: Stefan Wahren <stefan.wahren@i2se.com> Sent: Thursday, June 09, 2016 4:43 AM
> To: David Miller <davem@davemloft.net>; Fugang Duan
> <fugang.duan@nxp.com>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>; Lucas Stach
> <l.stach@pengutronix.de>; andrew@lunn.ch; holgerschurig@gmail.com; Troy
> Kisky <troy.kisky@boundarydevices.com>; linux-arm-kernel@lists.infradead.org;
> netdev@vger.kernel.org; Stefan Wahren <stefan.wahren@i2se.com>
> Subject: [PATCH net-next RFT] net: fec: handle small PHY reset durations more
> precisely
>
> Since msleep is based on jiffies the PHY reset could take longer than expected.
> So use msleep for values greater than 20 msec otherwise usleep_range.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 3c0255e..49f8055 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3191,7 +3191,12 @@ static void fec_reset_phy(struct platform_device
> *pdev)
> dev_err(&pdev->dev, "failed to get phy-reset-gpios: %d\n", err);
> return;
> }
> - msleep(msec);
> +
> + if (msec > 20)
> + msleep(msec);
> + else
> + usleep_range(msec * 1000, msec * 1000 + 1000);
> +
> gpio_set_value_cansleep(phy_reset, !active_high); } #else /*
> CONFIG_OF */
> --
> 1.7.9.5
Thanks. You are correct base on Documentation/timers/timers-howto.txt.
Acked-by: Fugang Duan <fugang.duan@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely
2016-06-08 20:42 [PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely Stefan Wahren
2016-06-12 5:16 ` Fugang Duan
@ 2016-06-13 1:58 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-06-13 1:58 UTC (permalink / raw)
To: stefan.wahren
Cc: fugang.duan, fabio.estevam, l.stach, andrew, holgerschurig,
troy.kisky, linux-arm-kernel, netdev
From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Wed, 8 Jun 2016 20:42:46 +0000
> Since msleep is based on jiffies the PHY reset could take longer
> than expected. So use msleep for values greater than 20 msec otherwise
> usleep_range.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-13 1:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-08 20:42 [PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely Stefan Wahren
2016-06-12 5:16 ` Fugang Duan
2016-06-13 1:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).