netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	David Ahern <dsa@cumulusnetworks.com>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: [PATCH v3 net-next 0/5] net: better lockdep annotations
Date: Thu,  9 Jun 2016 07:45:10 -0700	[thread overview]
Message-ID: <1465483515-10821-1-git-send-email-edumazet@google.com> (raw)

Introduction of qdisc->running seqcount added lockdep false positives.

While chasing the bug, it came to me that we had a lot of copies of the
same stuff in virtual drivers.

This patch series has the qdisc->running fix (considers that a trylock
is attempted in lockdep terminology), and adds a generic helper so
that we no longer have to patch many virtual drivers when a new per-device
or per-qdisc lock is added.

Thanks to David Ahern for reporting the issue and testing my patches :)


Eric Dumazet (5):
  net: sched: fix qdisc->running lockdep annotations
  net: add netdev_lockdep_set_classes() helper
  net: vrf: call netdev_lockdep_set_classes()
  net: macvlan: call netdev_lockdep_set_classes()
  net: ipvlan: call netdev_lockdep_set_classes()

 drivers/net/bonding/bond_main.c  | 24 +-----------------------
 drivers/net/ipvlan/ipvlan_main.c | 22 +---------------------
 drivers/net/macvlan.c            | 11 +----------
 drivers/net/ppp/ppp_generic.c    |  6 +-----
 drivers/net/team/team.c          | 21 +--------------------
 drivers/net/vrf.c                |  2 +-
 include/linux/netdevice.h        | 17 +++++++++++++++++
 include/net/sch_generic.h        |  6 +++++-
 net/bluetooth/6lowpan.c          | 15 +--------------
 net/ieee802154/6lowpan/core.c    | 16 +---------------
 net/l2tp/l2tp_eth.c              |  6 +-----
 net/sched/sch_generic.c          |  4 ++--
 12 files changed, 33 insertions(+), 117 deletions(-)

-- 
2.8.0.rc3.226.g39d4020

             reply	other threads:[~2016-06-09 14:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 14:45 Eric Dumazet [this message]
2016-06-09 14:45 ` [PATCH v3 net-next 1/5] net: sched: fix qdisc->running lockdep annotations Eric Dumazet
2016-06-09 14:45 ` [PATCH v3 net-next 2/5] net: add netdev_lockdep_set_classes() helper Eric Dumazet
2016-06-09 14:45 ` [PATCH v3 net-next 3/5] net: vrf: call netdev_lockdep_set_classes() Eric Dumazet
2016-06-09 15:05   ` David Ahern
2016-06-09 14:45 ` [PATCH v3 net-next 4/5] net: macvlan: " Eric Dumazet
2016-06-09 14:45 ` [PATCH v3 net-next 5/5] net: ipvlan: " Eric Dumazet
2016-06-09 20:29 ` [PATCH v3 net-next 0/5] net: better lockdep annotations David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465483515-10821-1-git-send-email-edumazet@google.com \
    --to=edumazet@google.com \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).