[PATCH] [V2] net: ipconfig: add declaration for ic_addrservaddr

[PATCH] [V2] net: ipconfig: add declaration for ic_addrservaddr

[Ben Dooks]

The symbol ic_addrservaddr is not static, but has no declaration
to match so make it static to fix the following warning:

net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
V2: make ic_addrservaddr static instead of adding to header
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: James Morris <jmorris@namei.org>
Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Cc: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org
---
 net/ipv4/ipconfig.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 2ed9dd2..eccf9fd 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -127,7 +127,7 @@ __be32 ic_myaddr = NONE;		/* My IP address */
 static __be32 ic_netmask = NONE;	/* Netmask for local subnet */
 __be32 ic_gateway = NONE;	/* Gateway IP address */
 
-__be32 ic_addrservaddr = NONE;	/* IP Address of the IP addresses'server */
+static __be32 ic_addrservaddr = NONE;	/* IP Address of the IP addresses'server */
 
 __be32 ic_servaddr = NONE;	/* Boot server IP address */
 
-- 
2.8.1

Re: [PATCH] [V2] net: ipconfig: add declaration for ic_addrservaddr

[David Miller]

From: Ben Dooks <ben.dooks@codethink.co.uk>
Date: Thu,  9 Jun 2016 18:54:37 +0100

> The symbol ic_addrservaddr is not static, but has no declaration
> to match so make it static to fix the following warning:
> 
> net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Your Subject line needs to be updated, you're not ading a declaration
any more.

Re: [PATCH] [V2] net: ipconfig: add declaration for ic_addrservaddr

[Ben Dooks]

On 09/06/16 21:35, David Miller wrote:
> From: Ben Dooks <ben.dooks@codethink.co.uk>
> Date: Thu,  9 Jun 2016 18:54:37 +0100
> 
>> The symbol ic_addrservaddr is not static, but has no declaration
>> to match so make it static to fix the following warning:
>>
>> net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not declared. Should it be static?
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> 
> Your Subject line needs to be updated, you're not ading a declaration
> any more.

OOPS. Will fix and re-send thanks.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius