* [PATCH net] ipv6: fix endianness error in icmpv6_err
@ 2016-06-11 18:32 Hannes Frederic Sowa
2016-06-12 3:38 ` Lorenzo Colitti
2016-06-14 19:25 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Hannes Frederic Sowa @ 2016-06-11 18:32 UTC (permalink / raw)
To: netdev; +Cc: Lorenzo Colitti
IPv6 ping socket error handler doesn't correctly convert the new 32 bit
mtu to host endianness before using.
Cc: Lorenzo Colitti <lorenzo@google.com>
Fixes: 6d0bfe22611602f ("net: ipv6: Add IPv6 support to the ping socket.")
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
---
net/ipv6/icmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
index 4527285fcaa2c2..a4fa840769690a 100644
--- a/net/ipv6/icmp.c
+++ b/net/ipv6/icmp.c
@@ -98,7 +98,7 @@ static void icmpv6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
if (!(type & ICMPV6_INFOMSG_MASK))
if (icmp6->icmp6_type == ICMPV6_ECHO_REQUEST)
- ping_err(skb, offset, info);
+ ping_err(skb, offset, ntohl(info));
}
static int icmpv6_rcv(struct sk_buff *skb);
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] ipv6: fix endianness error in icmpv6_err
2016-06-11 18:32 [PATCH net] ipv6: fix endianness error in icmpv6_err Hannes Frederic Sowa
@ 2016-06-12 3:38 ` Lorenzo Colitti
2016-06-14 19:25 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Colitti @ 2016-06-12 3:38 UTC (permalink / raw)
To: Hannes Frederic Sowa; +Cc: netdev@vger.kernel.org
On Sun, Jun 12, 2016 at 3:32 AM, Hannes Frederic Sowa
<hannes@stressinduktion.org> wrote:
> IPv6 ping socket error handler doesn't correctly convert the new 32 bit
> mtu to host endianness before using.
> ...
> if (!(type & ICMPV6_INFOMSG_MASK))
> if (icmp6->icmp6_type == ICMPV6_ECHO_REQUEST)
> - ping_err(skb, offset, info);
> + ping_err(skb, offset, ntohl(info));
> }
Acked-by: Lorenzo Colitti <lorenzo@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] ipv6: fix endianness error in icmpv6_err
2016-06-11 18:32 [PATCH net] ipv6: fix endianness error in icmpv6_err Hannes Frederic Sowa
2016-06-12 3:38 ` Lorenzo Colitti
@ 2016-06-14 19:25 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-06-14 19:25 UTC (permalink / raw)
To: hannes; +Cc: netdev, lorenzo
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sat, 11 Jun 2016 20:32:06 +0200
> IPv6 ping socket error handler doesn't correctly convert the new 32 bit
> mtu to host endianness before using.
>
> Cc: Lorenzo Colitti <lorenzo@google.com>
> Fixes: 6d0bfe22611602f ("net: ipv6: Add IPv6 support to the ping socket.")
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-14 19:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-11 18:32 [PATCH net] ipv6: fix endianness error in icmpv6_err Hannes Frederic Sowa
2016-06-12 3:38 ` Lorenzo Colitti
2016-06-14 19:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).