From: Ben Hutchings <ben@decadent.org.uk>
To: David Miller <davem@davemloft.net>, vidya@cumulusnetworks.com
Cc: bwh@kernel.org, netdev@vger.kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes
Date: Sun, 12 Jun 2016 13:33:04 +0100 [thread overview]
Message-ID: <1465734784.3529.147.camel@decadent.org.uk> (raw)
In-Reply-To: <20160611.155134.1474324006340328110.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
On Sat, 2016-06-11 at 15:51 -0700, David Miller wrote:
[...]
> Why do we need these values in the header file at all?
Because we don't like putting magic numbers in driver code, and these
sizes are defined by standards that are independent of a single driver.
> The application can probe the size by repeated eeprom calls, increasing
> the buffer size each time as needed until success.
But really it should use ETHTOOL_GMODULEINFO first.
Ben.
--
Ben Hutchings
The program is absolutely right; therefore, the computer must be wrong.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-06-12 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 5:55 [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes vidya
2016-06-11 22:51 ` David Miller
2016-06-11 23:22 ` Vidya Sagar Ravipati
2016-06-12 2:26 ` David Miller
2016-06-12 12:34 ` Ben Hutchings
2016-06-14 19:29 ` David Miller
2016-06-12 12:33 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465734784.3529.147.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=bwh@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=vidya@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).