From: Ben Hutchings <ben@decadent.org.uk>
To: David Miller <davem@davemloft.net>, vidya@cumulusnetworks.com
Cc: bwh@kernel.org, netdev@vger.kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes
Date: Sun, 12 Jun 2016 13:34:12 +0100 [thread overview]
Message-ID: <1465734852.3529.148.camel@decadent.org.uk> (raw)
In-Reply-To: <20160611.192648.91885921700006865.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
On Sat, 2016-06-11 at 19:26 -0700, David Miller wrote:
> From: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
> Date: Sat, 11 Jun 2016 16:22:38 -0700
>
> > As part of ethtool application, application is requesting the drivers
> > to provide the supported eeprom size to allocate memory buffer for
> > getting complete dump.
>
> And the right way to do that is the driver requests the eeprom info
> with a buffer size of zero, then the driver fills in the size field
> for what the size actually is.
>
> Then the application can allocate the proper buffer size and rerun
> the eeprom request.
>
> Putting endless values for each and every eeprom type a device has is
> just rediculous.
>
> I'm not going to continue promoting this broken and unscalable scheme,
> we have to fix this.
I don't think there's nothing broken here. ethtool doesn't use those
macros, the drivers do.
Ben.
--
Ben Hutchings
The program is absolutely right; therefore, the computer must be wrong.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-12 12:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 5:55 [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes vidya
2016-06-11 22:51 ` David Miller
2016-06-11 23:22 ` Vidya Sagar Ravipati
2016-06-12 2:26 ` David Miller
2016-06-12 12:34 ` Ben Hutchings [this message]
2016-06-14 19:29 ` David Miller
2016-06-12 12:33 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465734852.3529.148.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=bwh@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=vidya@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).