From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: David Ahern <dsa@cumulusnetworks.com>, netdev@vger.kernel.org
Cc: Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH net] fib_rules: don't break ECN with TOS rules
Date: Mon, 13 Jun 2016 23:49:45 +0200 [thread overview]
Message-ID: <1465854585.1443672.636616881.5FACCAD4@webmail.messagingengine.com> (raw)
In-Reply-To: <c5fb0fbf-6b8e-a479-198a-817ff9071d74@cumulusnetworks.com>
On Mon, Jun 13, 2016, at 00:18, David Ahern wrote:
> On 6/11/16 3:10 PM, Hannes Frederic Sowa wrote:
> > @@ -215,6 +216,9 @@ static int fib4_rule_configure(struct fib_rule *rule, struct sk_buff *skb,
> > rule4->dst_len = frh->dst_len;
> > rule4->dstmask = inet_make_mask(rule4->dst_len);
> > rule4->tos = frh->tos;
> > + if (!INET_ECN_ignore(rule4->tos))
> > + pr_warn("ipv4: never matching ipv4 rule with match for %x added\n",
> > + rule4->tos);
> >
>
> The wording of the warning message is not very clear on what the problem
> is.
I will redesign this whole patch and will improve those warnings, too.
Thanks,
Hannes
prev parent reply other threads:[~2016-06-13 21:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 21:10 [PATCH net] fib_rules: don't break ECN with TOS rules Hannes Frederic Sowa
2016-06-12 0:09 ` Julian Anastasov
2016-06-12 0:36 ` Hannes Frederic Sowa
2016-06-12 0:38 ` Hannes Frederic Sowa
2016-06-12 9:28 ` Julian Anastasov
2016-06-12 10:28 ` Hannes Frederic Sowa
2016-06-12 22:18 ` David Ahern
2016-06-13 21:49 ` Hannes Frederic Sowa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465854585.1443672.636616881.5FACCAD4@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=dsa@cumulusnetworks.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).