From: Phil Sutter <phil@nwl.cc>
To: Stephen Hemminger <shemming@brocade.com>
Cc: netdev@vger.kernel.org, Phil Sutter <psutter@redhat.com>
Subject: [iproute PATCH 2/2] tc: m_action: Drop unused variable nladdr in tc_action_gd()
Date: Wed, 15 Jun 2016 00:26:09 +0200 [thread overview]
Message-ID: <1465943169-4101-3-git-send-email-phil@nwl.cc> (raw)
In-Reply-To: <1465943169-4101-1-git-send-email-phil@nwl.cc>
From: Phil Sutter <psutter@redhat.com>
This has been there since the introduction of tc/m_action.c back in 2004
and was apparently never in use.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
tc/m_action.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tc/m_action.c b/tc/m_action.c
index 1b34370f4ec09..fd324090db1f2 100644
--- a/tc/m_action.c
+++ b/tc/m_action.c
@@ -386,7 +386,6 @@ static int tc_action_gd(int cmd, unsigned int flags, int *argc_p, char ***argv_p
int prio = 0;
int ret = 0;
__u32 i;
- struct sockaddr_nl nladdr;
struct rtattr *tail;
struct rtattr *tail2;
struct nlmsghdr *ans = NULL;
@@ -400,9 +399,6 @@ static int tc_action_gd(int cmd, unsigned int flags, int *argc_p, char ***argv_p
memset(&req, 0, sizeof(req));
req.t.tca_family = AF_UNSPEC;
- memset(&nladdr, 0, sizeof(nladdr));
- nladdr.nl_family = AF_NETLINK;
-
req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct tcamsg));
req.n.nlmsg_flags = NLM_F_REQUEST|flags;
req.n.nlmsg_type = cmd;
--
2.8.2
prev parent reply other threads:[~2016-06-14 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 22:26 [iproute PATCH 0/2] Two cosmetic fixes in tc/m_action.c Phil Sutter
2016-06-14 22:26 ` [iproute PATCH 1/2] tc: m_action: Fix for field init before memset Phil Sutter
2016-06-14 23:51 ` Stephen Hemminger
2016-06-14 22:26 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465943169-4101-3-git-send-email-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netdev@vger.kernel.org \
--cc=psutter@redhat.com \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).