From: Martin Willi <martin-jzJueiEJWxp8fCCB1iTX4w@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mac80211_hwsim: Allow wmediumd to attach to radios created in its netns
Date: Wed, 15 Jun 2016 14:37:13 +0200 [thread overview]
Message-ID: <1465994233.3807.18.camel@strongswan.org> (raw)
In-Reply-To: <1465978217.2994.4.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
>
> > printk(KERN_INFO "mac80211_hwsim: wmediumd released netlink"
> > " socket, switching to perfect channel medium\n");
> I wonder if we can do something better about them? Or perhaps if we
> should remove them, so other namespaces won't mess up the kernel log
This is in fact not very nice, but not specific to hwsim. Any namespace
can mess up the kernel log from different (networking) subsystems. This
has been discussed some time ago [1], but AFAIK there is no real
solution so far.
For this patch I think we have the following options:
* Keep the printk() messages as proposed
* Remove those callable from non-initial namespaces completely
* Suppress them when called from non-initial namespaces
* Include the associated "netgroup" in the message
I personally would prefer the first option, as this problem is not
specific to hwsim or mac80211, but many subsystems. So we certainly can
add some work-around, but there is not much to gain if other modules
don't.
Regards
Martin
[1]https://lwn.net/Articles/527342/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-15 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 8:34 [PATCH] mac80211_hwsim: Allow wmediumd to attach to radios created in its netns Martin Willi
[not found] ` <1463214884-5983-1-git-send-email-martin-jzJueiEJWxp8fCCB1iTX4w@public.gmane.org>
2016-06-15 8:10 ` Johannes Berg
[not found] ` <1465978217.2994.4.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-06-15 12:37 ` Martin Willi [this message]
[not found] ` <1465994233.3807.18.camel-jzJueiEJWxp8fCCB1iTX4w@public.gmane.org>
2016-06-15 12:51 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465994233.3807.18.camel@strongswan.org \
--to=martin-jzjueiejwxp8fccb1itx4w@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).