From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "venkateshs@google.com" <venkateshs@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>
Cc: "hannes@redhat.com" <hannes@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH net] ixgbe: napi_poll must return the work done
Date: Thu, 16 Jun 2016 17:43:18 +0000 [thread overview]
Message-ID: <1466098998.17117.22.camel@intel.com> (raw)
In-Reply-To: <CAHdzE-8V8o9sg9xmiJ9J0G3u=k6K-fHQssb5v09TPJvN2N=a1Q@mail.gmail.com>
On Wed, 2016-06-15 at 09:34 -0700, Venkatesh Srinivas wrote:
> Reviewed-by: Venkatesh Srinivas <venkateshs@google.com>
>
> The same bit of code appears in fm10k and i40e/i40evf. ixgb appears
> to
> correctly return work_done.
>
> ixgbe_poll also appears to return an (minor) incorrect work_done in
> another case, BTW. It divides its
> budget between Rx rings associated with a vector. If any ring exceeds
> its share of the budget, ixgbe_poll
> claims to have consumed the full budget, even if a full budget of
> frames was not received in a single
> pass.
>
So the correct return here would also be min between work_done and
budget, right? ie: we should still return the total work done instead
of the budget...?
Thanks,
Jake
> -- vs;
prev parent reply other threads:[~2016-06-16 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 13:37 [PATCH net] ixgbe: napi_poll must return the work done Paolo Abeni
2016-06-15 15:20 ` Alexander Duyck
2016-06-15 15:43 ` Paolo Abeni
2016-06-15 16:34 ` Venkatesh Srinivas
2016-06-16 17:10 ` Keller, Jacob E
2016-06-16 17:40 ` Keller, Jacob E
2016-06-16 17:43 ` Keller, Jacob E [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466098998.17117.22.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=davem@davemloft.net \
--cc=hannes@redhat.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=venkateshs@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).