From: Joe Perches <joe@perches.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Arnd Bergmann <arnd@arndb.de>,
netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Yangbo Lu <yangbo.lu@nxp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] net: gianfar: fix old-style declaration
Date: Thu, 16 Jun 2016 11:11:45 -0700 [thread overview]
Message-ID: <1466100705.19647.47.camel@perches.com> (raw)
In-Reply-To: <0d9320db-ae2c-03a2-eb20-e527a69c356b@cogentembedded.com>
On Thu, 2016-06-16 at 21:02 +0300, Sergei Shtylyov wrote:
> On 06/16/2016 04:52 PM, Arnd Bergmann wrote:
> > Modern C standards expect the '__inline__' keyword to come before the return
> > type in a declaration, and we get a warning for this with "make W=1":
[]
> > diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
[]
> > @@ -2275,7 +2275,7 @@ static inline void gfar_tx_checksum(struct sk_buff *skb, struct txfcb *fcb,
> > fcb->flags = flags;
> > }
> >
> > -void inline gfar_tx_vlan(struct sk_buff *skb, struct txfcb *fcb)
> > +static inline void gfar_tx_vlan(struct sk_buff *skb, struct txfcb *fcb)
> You don't mention making it *static*. Though the function can be *static*
> indeed... the current policy also forbids *inline* in the *.c files, leaving
> the judgement to gcc.
While mostly true, (__always_inline vs inline vs nothing),
there are many inline uses in this file that could be removed
in a separate patch rather than removing just this one.
next prev parent reply other threads:[~2016-06-16 18:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 13:50 [PATCH 0/8] net: fix old-style declarations Arnd Bergmann
2016-06-16 13:52 ` [PATCH 1/8] wireless: airo: rename 'register' variable Arnd Bergmann
2016-06-16 13:52 ` [PATCH 2/8] wireless: brcmsmac: fix old-style declaration Arnd Bergmann
2016-06-16 13:52 ` [PATCH 3/8] wireless: ipw2200: " Arnd Bergmann
2016-06-24 17:46 ` Stanislav Yakovlev
2016-06-16 13:52 ` [PATCH 4/8] hamradio: baycom: " Arnd Bergmann
2016-06-17 5:06 ` David Miller
2016-06-16 13:52 ` [PATCH 5/8] isdn: eicon: fix old-style declarations Arnd Bergmann
2016-06-17 5:06 ` David Miller
2016-06-16 13:52 ` [PATCH 6/8] net: gianfar: fix old-style declaration Arnd Bergmann
2016-06-16 18:02 ` Sergei Shtylyov
2016-06-16 18:11 ` Joe Perches [this message]
2016-06-17 5:06 ` David Miller
[not found] ` <20160616135245.3198419-1-arnd-r2nGTMty4D4@public.gmane.org>
2016-06-29 15:56 ` [1/8] wireless: airo: rename 'register' variable Kalle Valo
2016-06-16 13:57 ` [PATCH 8/8] sunrpc: fix old-style declaration Arnd Bergmann
2016-06-16 13:59 ` [PATCH 7/8] net: xfrm: " Arnd Bergmann
2016-06-17 5:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466100705.19647.47.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).