From: Joe Perches <joe@perches.com>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>,
nicolas.ferre@atmel.com, punnaia@xilinx.com, harinik@xilinx.com,
anirudh@xilinx.com, michals@xilinx.com, appanad@xilinx.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] net: macb: Add gmii2rgmii converter support
Date: Sun, 19 Jun 2016 23:06:25 -0700 [thread overview]
Message-ID: <1466402785.19647.138.camel@perches.com> (raw)
In-Reply-To: <1466400437-21277-1-git-send-email-appanad@xilinx.com>
On Mon, 2016-06-20 at 10:57 +0530, Kedareswara rao Appana wrote:
> This patch adds support for gmii2rgmii converter
> in the macb driver.
[]
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
[]
> @@ -376,6 +389,20 @@ static int macb_mii_probe(struct net_device *dev)
> int phy_irq;
> int ret;
>
> + if (bp->gmii2rgmii_phy_node) {
> + phydev = of_phy_attach(bp->dev,
> + bp->gmii2rgmii_phy_node,
> + 0, 0);
> + if (!phydev) {
> + dev_err(&bp->pdev->dev, "%s: no gmii_to_rgmii found\n",
> + dev->name);
why use dev_err(&bp->pdev->dev, ...) and not netdev_err(dev, ...) ?
prev parent reply other threads:[~2016-06-20 6:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 5:27 [RFC PATCH] net: macb: Add gmii2rgmii converter support Kedareswara rao Appana
2016-06-20 5:39 ` Florian Fainelli
2016-06-20 6:15 ` Appana Durga Kedareswara Rao
2016-06-20 6:06 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466402785.19647.138.camel@perches.com \
--to=joe@perches.com \
--cc=anirudh@xilinx.com \
--cc=appana.durga.rao@xilinx.com \
--cc=appanad@xilinx.com \
--cc=harinik@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=punnaia@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).