From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Sun Shouxin <sunshouxin@chinatelecom.cn>
Cc: vfalico@gmail.com, andy@greyhouse.net, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
huyd12@chinatelecom.cn
Subject: Re: [PATCH] bonding: Remove unnecessary check
Date: Mon, 22 Aug 2022 13:43:10 -0700 [thread overview]
Message-ID: <14667.1661200990@famine> (raw)
In-Reply-To: <20220822103130.3466-1-sunshouxin@chinatelecom.cn>
Sun Shouxin <sunshouxin@chinatelecom.cn> wrote:
>This check is not necessary since the commit d5410ac7b0ba
>("net:bonding:support balance-alb interface with vlan to bridge").
Please explain why this assertion is correct in your commit
message.
Also, I presume this is for net-next; please specify in the
PATCH block of the Subject.
-J
>Suggested-by: Hu Yadi <huyd12@chinatelecom.cn>
>Signed-off-by: Sun Shouxin <sunshouxin@chinatelecom.cn>
>---
> drivers/net/bonding/bond_main.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 50e60843020c..6b0f0ce9b9a1 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -1578,19 +1578,6 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
>
> skb->dev = bond->dev;
>
>- if (BOND_MODE(bond) == BOND_MODE_ALB &&
>- netif_is_bridge_port(bond->dev) &&
>- skb->pkt_type == PACKET_HOST) {
>-
>- if (unlikely(skb_cow_head(skb,
>- skb->data - skb_mac_header(skb)))) {
>- kfree_skb(skb);
>- return RX_HANDLER_CONSUMED;
>- }
>- bond_hw_addr_copy(eth_hdr(skb)->h_dest, bond->dev->dev_addr,
>- bond->dev->addr_len);
>- }
>-
> return ret;
> }
>
>--
>2.27.0
>
---
-Jay Vosburgh, jay.vosburgh@canonical.com
prev parent reply other threads:[~2022-08-22 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 10:31 [PATCH] bonding: Remove unnecessary check Sun Shouxin
2022-08-22 20:29 ` Eric Dumazet
2022-08-22 20:43 ` Jay Vosburgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14667.1661200990@famine \
--to=jay.vosburgh@canonical.com \
--cc=andy@greyhouse.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=huyd12@chinatelecom.cn \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sunshouxin@chinatelecom.cn \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).