* [PATCH] bonding: Remove unnecessary check
@ 2022-08-22 10:31 Sun Shouxin
2022-08-22 20:29 ` Eric Dumazet
2022-08-22 20:43 ` Jay Vosburgh
0 siblings, 2 replies; 3+ messages in thread
From: Sun Shouxin @ 2022-08-22 10:31 UTC (permalink / raw)
To: j.vosburgh, vfalico, andy, davem, edumazet, kuba, pabeni, ast,
daniel, hawk, john.fastabend
Cc: netdev, linux-kernel, bpf, huyd12, sunshouxin
This check is not necessary since the commit d5410ac7b0ba
("net:bonding:support balance-alb interface with vlan to bridge").
Suggested-by: Hu Yadi <huyd12@chinatelecom.cn>
Signed-off-by: Sun Shouxin <sunshouxin@chinatelecom.cn>
---
drivers/net/bonding/bond_main.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 50e60843020c..6b0f0ce9b9a1 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1578,19 +1578,6 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
skb->dev = bond->dev;
- if (BOND_MODE(bond) == BOND_MODE_ALB &&
- netif_is_bridge_port(bond->dev) &&
- skb->pkt_type == PACKET_HOST) {
-
- if (unlikely(skb_cow_head(skb,
- skb->data - skb_mac_header(skb)))) {
- kfree_skb(skb);
- return RX_HANDLER_CONSUMED;
- }
- bond_hw_addr_copy(eth_hdr(skb)->h_dest, bond->dev->dev_addr,
- bond->dev->addr_len);
- }
-
return ret;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bonding: Remove unnecessary check
2022-08-22 10:31 [PATCH] bonding: Remove unnecessary check Sun Shouxin
@ 2022-08-22 20:29 ` Eric Dumazet
2022-08-22 20:43 ` Jay Vosburgh
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2022-08-22 20:29 UTC (permalink / raw)
To: Sun Shouxin
Cc: Jay Vosburgh, Veaceslav Falico, Andy Gospodarek, David Miller,
Jakub Kicinski, Paolo Abeni, Alexei Starovoitov, Daniel Borkmann,
Jesper Dangaard Brouer, John Fastabend, netdev, LKML, bpf, huyd12
On Mon, Aug 22, 2022 at 3:33 AM Sun Shouxin <sunshouxin@chinatelecom.cn> wrote:
>
> This check is not necessary since the commit d5410ac7b0ba
> ("net:bonding:support balance-alb interface with vlan to bridge").
Please provide more details. I fail to see the relation between d5410ac7b0ba
and this patch, thanks.
>
> Suggested-by: Hu Yadi <huyd12@chinatelecom.cn>
> Signed-off-by: Sun Shouxin <sunshouxin@chinatelecom.cn>
> ---
> drivers/net/bonding/bond_main.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 50e60843020c..6b0f0ce9b9a1 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1578,19 +1578,6 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
>
> skb->dev = bond->dev;
>
> - if (BOND_MODE(bond) == BOND_MODE_ALB &&
> - netif_is_bridge_port(bond->dev) &&
> - skb->pkt_type == PACKET_HOST) {
> -
> - if (unlikely(skb_cow_head(skb,
> - skb->data - skb_mac_header(skb)))) {
> - kfree_skb(skb);
> - return RX_HANDLER_CONSUMED;
> - }
> - bond_hw_addr_copy(eth_hdr(skb)->h_dest, bond->dev->dev_addr,
> - bond->dev->addr_len);
> - }
> -
> return ret;
> }
>
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bonding: Remove unnecessary check
2022-08-22 10:31 [PATCH] bonding: Remove unnecessary check Sun Shouxin
2022-08-22 20:29 ` Eric Dumazet
@ 2022-08-22 20:43 ` Jay Vosburgh
1 sibling, 0 replies; 3+ messages in thread
From: Jay Vosburgh @ 2022-08-22 20:43 UTC (permalink / raw)
To: Sun Shouxin
Cc: vfalico, andy, davem, edumazet, kuba, pabeni, ast, daniel, hawk,
john.fastabend, netdev, linux-kernel, bpf, huyd12
Sun Shouxin <sunshouxin@chinatelecom.cn> wrote:
>This check is not necessary since the commit d5410ac7b0ba
>("net:bonding:support balance-alb interface with vlan to bridge").
Please explain why this assertion is correct in your commit
message.
Also, I presume this is for net-next; please specify in the
PATCH block of the Subject.
-J
>Suggested-by: Hu Yadi <huyd12@chinatelecom.cn>
>Signed-off-by: Sun Shouxin <sunshouxin@chinatelecom.cn>
>---
> drivers/net/bonding/bond_main.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 50e60843020c..6b0f0ce9b9a1 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -1578,19 +1578,6 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
>
> skb->dev = bond->dev;
>
>- if (BOND_MODE(bond) == BOND_MODE_ALB &&
>- netif_is_bridge_port(bond->dev) &&
>- skb->pkt_type == PACKET_HOST) {
>-
>- if (unlikely(skb_cow_head(skb,
>- skb->data - skb_mac_header(skb)))) {
>- kfree_skb(skb);
>- return RX_HANDLER_CONSUMED;
>- }
>- bond_hw_addr_copy(eth_hdr(skb)->h_dest, bond->dev->dev_addr,
>- bond->dev->addr_len);
>- }
>-
> return ret;
> }
>
>--
>2.27.0
>
---
-Jay Vosburgh, jay.vosburgh@canonical.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-22 20:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-22 10:31 [PATCH] bonding: Remove unnecessary check Sun Shouxin
2022-08-22 20:29 ` Eric Dumazet
2022-08-22 20:43 ` Jay Vosburgh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).