From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH net-next 6/9] net: hns: normalize two different loop Date: Mon, 27 Jun 2016 04:49:21 -0700 Message-ID: <1467028161.1847.101.camel@perches.com> References: <1467021255-95900-1-git-send-email-Yisen.Zhuang@huawei.com> <1467021255-95900-7-git-send-email-Yisen.Zhuang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: liguozhu@huawei.com, huangdaode@hisilicon.com, arnd@arndb.de, andriy.shevchenko@linux.intel.com, andrew@lunn.ch, geliangtang@163.com, ivecera@redhat.com, fengguang.wu@intel.com, charles.chenxin@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com To: Yisen Zhuang , davem@davemloft.net, salil.mehta@huawei.com, yankejian@huawei.com Return-path: Received: from smtprelay0018.hostedemail.com ([216.40.44.18]:47369 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751215AbcF0Lt0 (ORCPT ); Mon, 27 Jun 2016 07:49:26 -0400 In-Reply-To: <1467021255-95900-7-git-send-email-Yisen.Zhuang@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2016-06-27 at 17:54 +0800, Yisen Zhuang wrote: > From: Daode Huang >=20 > There are two approaches to assign data, one does 2 loops, another > does 1 loop. This patch normalize the different methods to 1 loop. [] > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/dri= vers/net/ethernet/hisilicon/hns/hns_dsaf_main.c [] > @@ -2567,15 +2567,15 @@ static char *hns_dsaf_get_node_stats_strings(= char *data, int node, > =A0 buff +=3D ETH_GSTRING_LEN; > =A0 if (node < DSAF_SERVICE_NW_NUM && !is_ver1) { > =A0 for (i =3D 0; i < DSAF_PRIO_NR; i++) { > - snprintf(buff, ETH_GSTRING_LEN, > - =A0"inod%d_pfc_prio%d_pkts", node, i); > - buff +=3D ETH_GSTRING_LEN; > - } > - for (i =3D 0; i < DSAF_PRIO_NR; i++) { > - snprintf(buff, ETH_GSTRING_LEN, > - =A0"onod%d_pfc_prio%d_pkts", node, i); > + snprintf(buff + 0 * ETH_GSTRING_LEN * DSAF_PRIO_NR, > + =A0ETH_GSTRING_LEN, "inod%d_pfc_prio%d_pkts", > + =A0node, i); > + snprintf(buff + 1 * ETH_GSTRING_LEN * DSAF_PRIO_NR, > + =A0ETH_GSTRING_LEN, "onod%d_pfc_prio%d_pkts", > + =A0node, i); > =A0 buff +=3D ETH_GSTRING_LEN; This looks odd and likely incorrect. > =A0 } > + buff +=3D 1 * DSAF_PRIO_NR * ETH_GSTRING_LEN; > =A0 }