From: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <Yuval.Mintz@qlogic.com>,
<sudarsana.kalluru@qlogic.com>
Subject: [PATCH net-next 2/2] qede: Fix the static checker warnings.
Date: Tue, 28 Jun 2016 02:10:59 -0400 [thread overview]
Message-ID: <1467094259-16061-3-git-send-email-sudarsana.kalluru@qlogic.com> (raw)
In-Reply-To: <1467094259-16061-1-git-send-email-sudarsana.kalluru@qlogic.com>
Static checker warnings:
drivers/net/ethernet/qlogic/qede/qede_ethtool.c:435 qede_get_coalesce()
warn: passing casted pointer '&coal->rx_coalesce_usecs' to
'edev->ops->common->get_coalesce()' 32 vs 16.
The u32 pointer is being typecasted to u16 which may fail for big-endian
platforms.
Fixes: d552fa84cb35 ("qede: Add support for coalescing config read/update.")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
---
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
index 6228482..c5c658a 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
@@ -430,11 +430,13 @@ static int qede_get_coalesce(struct net_device *dev,
struct ethtool_coalesce *coal)
{
struct qede_dev *edev = netdev_priv(dev);
+ u16 rxc, txc;
memset(coal, 0, sizeof(struct ethtool_coalesce));
- edev->ops->common->get_coalesce(edev->cdev,
- (u16 *)&coal->rx_coalesce_usecs,
- (u16 *)&coal->tx_coalesce_usecs);
+ edev->ops->common->get_coalesce(edev->cdev, &rxc, &txc);
+
+ coal->rx_coalesce_usecs = rxc;
+ coal->tx_coalesce_usecs = txc;
return 0;
}
--
1.8.3.1
next prev parent reply other threads:[~2016-06-28 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 6:10 [PATCH net-next 0/2] qed*: Fix the static checker warnings Sudarsana Reddy Kalluru
2016-06-28 6:10 ` [PATCH net-next 1/2] qed: Fix " Sudarsana Reddy Kalluru
2016-06-28 6:10 ` Sudarsana Reddy Kalluru [this message]
2016-06-29 11:59 ` [PATCH net-next 0/2] qed*: Fix the " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467094259-16061-3-git-send-email-sudarsana.kalluru@qlogic.com \
--to=sudarsana.kalluru@qlogic.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).