From: Tien Hock Loh <thloh@altera.com>
To: David Miller <davem@davemloft.net>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
<peppe.cavallaro@st.com>, <alexandre.torgue@st.com>,
<preid@electromag.com.au>, <dinguyen@opensource.altera.com>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <thloh85@gmail.com>,
<cnphoon@altera.com>
Subject: Re: [PATCH V5 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga
Date: Tue, 28 Jun 2016 02:58:55 -0700 [thread overview]
Message-ID: <1467107935.2700.2.camel@ubuntu> (raw)
In-Reply-To: <20160628.054815.1440008157228833144.davem@davemloft.net>
My fault, I wasn't testing against building as module, was always
building as part of the kernel. I'll get it fixed and put another patch
for review.
Thanks
Tien Hock
On Tue, 2016-06-28 at 05:48 -0400, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 28 Jun 2016 05:34:50 -0400 (EDT)
>
> > From: <thloh@altera.com>
> > Date: Fri, 24 Jun 2016 02:13:23 -0700
> >
> >> From: Tien Hock Loh <thloh@altera.com>
> >>
> >> This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
> >> the dwmac is set to sgmii.
> >>
> >> Signed-off-by: Tien Hock Loh <thloh@altera.com>
> >> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> >> Acked-by: Rob Herring <robh@kernel.org>
> >
> > Applied to net-next, thanks.
>
> I had to revert, this breaks the build:
>
> ERROR: "tse_pcs_fix_mac_speed" [drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.ko] undefined!
> ERROR: "tse_pcs_init" [drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.ko] undefined!
prev parent reply other threads:[~2016-06-28 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 9:13 [PATCH V5 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga thloh
[not found] ` <1466759603-30769-1-git-send-email-thloh-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
2016-06-28 9:34 ` David Miller
2016-06-28 9:48 ` David Miller
2016-06-28 9:58 ` Tien Hock Loh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467107935.2700.2.camel@ubuntu \
--to=thloh@altera.com \
--cc=alexandre.torgue@st.com \
--cc=cnphoon@altera.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
--cc=thloh85@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).