From: Phil Sutter <phil@nwl.cc>
To: Stephen Hemminger <shemming@brocade.com>
Cc: netdev@vger.kernel.org
Subject: [iproute PATCH 0/2] ip-address: fix type list inconsistencies
Date: Tue, 28 Jun 2016 15:07:15 +0200 [thread overview]
Message-ID: <1467119237-12544-1-git-send-email-phil@nwl.cc> (raw)
The basic problem was differences in type list reported by help output
and stated in man page.
I decided to tackle the problem from both sides:
a) Make sure 'ip addr show' supports matching on all types reported.
b) Add missing types in either list.
This is still rather best-effort, actually things are quite messed up:
- Lists are not sorted, it's easy to miss something.
- The type list is duplicated four times as ip-link help and man page
contain it, too.
- The kernel supports more types than listed here.
- We can't add but match on all types the kernel supports.
Phil Sutter (2):
ip-address: Support filtering by slave type, too
ip-address: Align type list in help and man page
ip/ipaddress.c | 58 +++++++++++++++++++++++++++---------------------
man/man8/ip-address.8.in | 3 +++
2 files changed, 36 insertions(+), 25 deletions(-)
--
2.8.2
next reply other threads:[~2016-06-28 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 13:07 Phil Sutter [this message]
2016-06-28 13:07 ` [iproute PATCH 1/2] ip-address: Support filtering by slave type, too Phil Sutter
2016-06-29 1:19 ` David Ahern
2016-06-30 0:11 ` Stephen Hemminger
2016-06-30 14:47 ` [iproute PATCH] ip-address: constify match_link_kind arg Phil Sutter
2016-06-28 13:07 ` [iproute PATCH 2/2] ip-address: Align type list in help and man page Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467119237-12544-1-git-send-email-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netdev@vger.kernel.org \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).