From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Catherine Sullivan <catherine.sullivan@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 10/16] i40e: Fix RSS to not be limited by the number of CPUs
Date: Tue, 28 Jun 2016 21:40:56 -0700 [thread overview]
Message-ID: <1467175262-54719-11-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1467175262-54719-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Catherine Sullivan <catherine.sullivan@intel.com>
Limiting qcount to pf->num_lan_msix, effectively limits the RSS queues
to only use the number of CPUs, and ignore all other queues. We don't
want to do this. If the user has changed the RSS settings to use more
queues then CPUS, we want to trust they know what they are doing and
let them. More importantly, if we tell them that is what we did, we want
to actually do it and allow traffic into all of the queues we have
allocated. This does not change the default setting to initially
allocate only the number of CPUS of queue pairs.
Change-ID: Ie941a96e806e4bcd016addb4e17affb46770ada5
Signed-off-by: Catherine Sullivan <catherine.sullivan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 52d9d28..a32be7c 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -1579,14 +1579,8 @@ static void i40e_vsi_setup_queue_map(struct i40e_vsi *vsi,
vsi->tc_config.numtc = numtc;
vsi->tc_config.enabled_tc = enabled_tc ? enabled_tc : 1;
/* Number of queues per enabled TC */
- /* In MFP case we can have a much lower count of MSIx
- * vectors available and so we need to lower the used
- * q count.
- */
- if (pf->flags & I40E_FLAG_MSIX_ENABLED)
- qcount = min_t(int, vsi->alloc_queue_pairs, pf->num_lan_msix);
- else
- qcount = vsi->alloc_queue_pairs;
+ qcount = vsi->alloc_queue_pairs;
+
num_tc_qps = qcount / numtc;
num_tc_qps = min_t(int, num_tc_qps, i40e_pf_get_max_q_per_tc(pf));
--
2.5.5
next prev parent reply other threads:[~2016-06-29 4:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 4:40 [net-next 00/16][pull request] 40GbE Intel Wired LAN Driver Updates 2016-06-27 Jeff Kirsher
2016-06-29 4:40 ` [net-next 01/16] i40e: add functions to control default VSI Jeff Kirsher
2016-06-29 4:40 ` [net-next 02/16] i40e: add hw struct local variable Jeff Kirsher
2016-06-29 13:00 ` David Laight
2016-06-29 4:40 ` [net-next 03/16] i40e: write HENA for VFs Jeff Kirsher
2016-06-29 4:40 ` [net-next 04/16] i40e: Add a call to set the client interface down Jeff Kirsher
2016-06-29 4:40 ` [net-next 05/16] i40evf: don't overflow buffer Jeff Kirsher
2016-06-29 4:40 ` [net-next 06/16] i40e: Clean up MSIX IRQs before suspend Jeff Kirsher
2016-06-29 4:40 ` [net-next 07/16] i40e: Save PCI state " Jeff Kirsher
2016-06-29 14:49 ` Greg
2016-06-29 4:40 ` [net-next 08/16] i40e: fix missing DA cable check Jeff Kirsher
2016-06-29 4:40 ` [net-next 09/16] i40e: Removing unnecessary code which caused supported link mode bug Jeff Kirsher
2016-06-29 4:40 ` Jeff Kirsher [this message]
2016-06-29 4:40 ` [net-next 11/16] i40evf: always activate correct MAC address filter Jeff Kirsher
2016-06-29 4:40 ` [net-next 12/16] i40e: set default VSI without a reset Jeff Kirsher
2016-06-29 4:40 ` [net-next 13/16] i40e: add VSI info to macaddr messages Jeff Kirsher
2016-06-29 4:41 ` [net-next 14/16] i40e/i40evf: Bump version from 1.5.16 to 1.6.4 Jeff Kirsher
2016-06-29 4:41 ` [net-next 15/16] i40e: Fix errors resulted while turning off TSO Jeff Kirsher
2016-06-29 4:41 ` [net-next 16/16] i40e: Don't notify client(s) for DCB changes on all VSIs Jeff Kirsher
2016-06-29 12:23 ` [net-next 00/16][pull request] 40GbE Intel Wired LAN Driver Updates 2016-06-27 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467175262-54719-11-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=catherine.sullivan@intel.com \
--cc=davem@davemloft.net \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).