From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Neerav Parikh <neerav.parikh@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Usha Ketineni <usha.k.ketineni@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 16/16] i40e: Don't notify client(s) for DCB changes on all VSIs
Date: Tue, 28 Jun 2016 21:41:02 -0700 [thread overview]
Message-ID: <1467175262-54719-17-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1467175262-54719-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Neerav Parikh <neerav.parikh@intel.com>
When LLDP/DCBX change happens the i40e driver code flow tried to
notify the client(s) for each of the PF VSIs. This resulted into
kernel panic on the first VSI that didn't have any netdev
associated to it.
The DCB change notification to the client(s) should be done only
once for the PF/LAN VSI where the client(s) instances have been
added to. Also, move the notification call after the PF driver has
made changes related to the updated DCB configuration.
Signed-off-by: Neerav Parikh <neerav.parikh@intel.com>
Signed-off-by: Usha Ketineni <usha.k.ketineni@intel.com>
Tested-by: Ronald J Bynoe <ronald.j.bynoe@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index a313194..2b11405 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -4982,7 +4982,6 @@ static void i40e_dcb_reconfigure(struct i40e_pf *pf)
if (pf->vsi[v]->netdev)
i40e_dcbnl_set_all(pf->vsi[v]);
}
- i40e_notify_client_of_l2_param_changes(pf->vsi[v]);
}
}
@@ -5730,6 +5729,8 @@ static int i40e_handle_lldp_event(struct i40e_pf *pf,
i40e_service_event_schedule(pf);
} else {
i40e_pf_unquiesce_all_vsi(pf);
+ /* Notify the client for the DCB changes */
+ i40e_notify_client_of_l2_param_changes(pf->vsi[pf->lan_vsi]);
}
exit:
--
2.5.5
next prev parent reply other threads:[~2016-06-29 4:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 4:40 [net-next 00/16][pull request] 40GbE Intel Wired LAN Driver Updates 2016-06-27 Jeff Kirsher
2016-06-29 4:40 ` [net-next 01/16] i40e: add functions to control default VSI Jeff Kirsher
2016-06-29 4:40 ` [net-next 02/16] i40e: add hw struct local variable Jeff Kirsher
2016-06-29 13:00 ` David Laight
2016-06-29 4:40 ` [net-next 03/16] i40e: write HENA for VFs Jeff Kirsher
2016-06-29 4:40 ` [net-next 04/16] i40e: Add a call to set the client interface down Jeff Kirsher
2016-06-29 4:40 ` [net-next 05/16] i40evf: don't overflow buffer Jeff Kirsher
2016-06-29 4:40 ` [net-next 06/16] i40e: Clean up MSIX IRQs before suspend Jeff Kirsher
2016-06-29 4:40 ` [net-next 07/16] i40e: Save PCI state " Jeff Kirsher
2016-06-29 14:49 ` Greg
2016-06-29 4:40 ` [net-next 08/16] i40e: fix missing DA cable check Jeff Kirsher
2016-06-29 4:40 ` [net-next 09/16] i40e: Removing unnecessary code which caused supported link mode bug Jeff Kirsher
2016-06-29 4:40 ` [net-next 10/16] i40e: Fix RSS to not be limited by the number of CPUs Jeff Kirsher
2016-06-29 4:40 ` [net-next 11/16] i40evf: always activate correct MAC address filter Jeff Kirsher
2016-06-29 4:40 ` [net-next 12/16] i40e: set default VSI without a reset Jeff Kirsher
2016-06-29 4:40 ` [net-next 13/16] i40e: add VSI info to macaddr messages Jeff Kirsher
2016-06-29 4:41 ` [net-next 14/16] i40e/i40evf: Bump version from 1.5.16 to 1.6.4 Jeff Kirsher
2016-06-29 4:41 ` [net-next 15/16] i40e: Fix errors resulted while turning off TSO Jeff Kirsher
2016-06-29 4:41 ` Jeff Kirsher [this message]
2016-06-29 12:23 ` [net-next 00/16][pull request] 40GbE Intel Wired LAN Driver Updates 2016-06-27 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467175262-54719-17-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jogreene@redhat.com \
--cc=neerav.parikh@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
--cc=usha.k.ketineni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).