netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, yotamg@mellanox.com,
	eladr@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com,
	sfeldma@gmail.com, roopa@cumulusnetworks.com, andy@greyhouse.net,
	dsa@cumulusnetworks.com, tgraf@suug.ch, jhs@mojatatu.com,
	linville@tuxdriver.com, ivecera@redhat.com
Subject: [patch net-next 01/18] mlxsw: spectrum: Send untagged packets through a port netdev
Date: Sat,  2 Jul 2016 09:26:23 +0200	[thread overview]
Message-ID: <1467444400-9480-2-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1467444400-9480-1-git-send-email-jiri@resnulli.us>

From: Ido Schimmel <idosch@mellanox.com>

Port netdevs (e.g. swXpY) that are not bridged are represented in the
device using a vPort with VID=PVID=1 (the PVID vPort), as untagged
packets entering the switch are internally tagged with the PVID VLAN.
When these packets are routed through a different port netdev they
should egress untagged.

This wasn't a problem until now, as non-bridged traffic only originated
from the CPU, which transmits packets out of the port as-is.

When a vPort is created with VID 1 mark it as egress untagged.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index a453fff..afd06dc 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -816,6 +816,7 @@ int mlxsw_sp_port_add_vid(struct net_device *dev, __be16 __always_unused proto,
 {
 	struct mlxsw_sp_port *mlxsw_sp_port = netdev_priv(dev);
 	struct mlxsw_sp_port *mlxsw_sp_vport;
+	bool untagged = vid == 1;
 	int err;
 
 	/* VLAN 0 is added to HW filter when device goes up, but it is
@@ -859,7 +860,7 @@ int mlxsw_sp_port_add_vid(struct net_device *dev, __be16 __always_unused proto,
 		goto err_port_vid_learning_set;
 	}
 
-	err = mlxsw_sp_port_vlan_set(mlxsw_sp_vport, vid, vid, true, false);
+	err = mlxsw_sp_port_vlan_set(mlxsw_sp_vport, vid, vid, true, untagged);
 	if (err) {
 		netdev_err(dev, "Failed to set VLAN membership for VID=%d\n",
 			   vid);
-- 
2.5.5

  reply	other threads:[~2016-07-02  7:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-02  7:26 [patch net-next 00/18] mlxsw: Do preparations before ipv4 router offload introduction Jiri Pirko
2016-07-02  7:26 ` Jiri Pirko [this message]
2016-07-02  7:26 ` [patch net-next 02/18] mlxsw: spectrum: Remove VLANs configuration via SELF flag Jiri Pirko
2016-07-02  7:26 ` [patch net-next 03/18] mlxsw: spectrum: Sync PVID vPort LAG status Jiri Pirko
2016-07-02  7:26 ` [patch net-next 04/18] mlxsw: spectrum: Remove RIF from PVID vPort when joining / leaving LAG Jiri Pirko
2016-07-02  7:26 ` [patch net-next 05/18] mlxsw: reg: Add Router General Configuration Register Jiri Pirko
2016-07-02  7:26 ` [patch net-next 06/18] mlxsw: spectrum: Initialize ports at the end of init sequence Jiri Pirko
2016-07-02  7:26 ` [patch net-next 07/18] mlxsw: spectrum_router: Add basic ipv4 router initialization Jiri Pirko
2016-07-02  7:26 ` [patch net-next 08/18] mlxsw: spectrum: Add router interface struct Jiri Pirko
2016-07-02  7:26 ` [patch net-next 09/18] mlxsw: reg: Add FDB action to forward to router Jiri Pirko
2016-07-02  7:26 ` [patch net-next 10/18] mlxsw: reg: Add Router Interface Table Register Jiri Pirko
2016-07-02  7:26 ` [patch net-next 11/18] mlxsw: spectrum: Use action 'discard' when removing traps Jiri Pirko
2016-07-02  7:26 ` [patch net-next 12/18] mlxsw: spectrum: Add traps needed for router implementation Jiri Pirko
2016-07-02  7:26 ` [patch net-next 13/18] mlxsw: spectrum: Add couple of lower device helper functions Jiri Pirko
2016-07-02  7:26 ` [patch net-next 14/18] mlxsw: spectrum: Edit RIF properties based on netdev events Jiri Pirko
2016-07-02  7:26 ` [patch net-next 15/18] mlxsw: spectrum: Introduce support for router interfaces Jiri Pirko
2016-07-02  7:26 ` [patch net-next 16/18] mlxsw: spectrum: Unsplit the vFID range Jiri Pirko
2016-07-02  7:26 ` [patch net-next 17/18] mlxsw: spectrum: Configure FIDs based on bridge events Jiri Pirko
2016-07-02  7:26 ` [patch net-next 18/18] mlxsw: spectrum: Enable L3 interfaces on top of bridge devices Jiri Pirko
2016-07-02  8:37 ` [patch net-next 00/18] mlxsw: Do preparations before ipv4 router offload introduction Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467444400-9480-2-git-send-email-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=eladr@mellanox.com \
    --cc=idosch@mellanox.com \
    --cc=ivecera@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=nogahf@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=sfeldma@gmail.com \
    --cc=tgraf@suug.ch \
    --cc=yotamg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).