netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, yotamg@mellanox.com,
	eladr@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com,
	sfeldma@gmail.com, roopa@cumulusnetworks.com, andy@greyhouse.net,
	dsa@cumulusnetworks.com, tgraf@suug.ch, jhs@mojatatu.com,
	linville@tuxdriver.com, ivecera@redhat.com
Subject: [patch net-next 03/18] mlxsw: spectrum: Sync PVID vPort LAG status
Date: Sat,  2 Jul 2016 09:26:25 +0200	[thread overview]
Message-ID: <1467444400-9480-4-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1467444400-9480-1-git-send-email-jiri@resnulli.us>

From: Ido Schimmel <idosch@mellanox.com>

When VLAN devices are created on top of LAG, their underlying vPorts are
configured correctly with LAG membership.

However, the PVID vPort is implicit and already present when the port
netdev is put under LAG, so its LAG membership is never set. Set it
correctly when joining / leaving LAG.

This didn't matter until now, but we are going to introduce support for
router interfaces (RIFs), which need to take into account LAG membership.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 31 ++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index 4f67a8c..f276c45 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -2795,6 +2795,32 @@ static int mlxsw_sp_port_lag_index_get(struct mlxsw_sp *mlxsw_sp,
 	return -EBUSY;
 }
 
+static void
+mlxsw_sp_port_pvid_vport_lag_join(struct mlxsw_sp_port *mlxsw_sp_port,
+				  u16 lag_id)
+{
+	struct mlxsw_sp_port *mlxsw_sp_vport;
+
+	mlxsw_sp_vport = mlxsw_sp_port_vport_find(mlxsw_sp_port, 1);
+	if (WARN_ON(!mlxsw_sp_vport))
+		return;
+
+	mlxsw_sp_vport->lag_id = lag_id;
+	mlxsw_sp_vport->lagged = 1;
+}
+
+static void
+mlxsw_sp_port_pvid_vport_lag_leave(struct mlxsw_sp_port *mlxsw_sp_port)
+{
+	struct mlxsw_sp_port *mlxsw_sp_vport;
+
+	mlxsw_sp_vport = mlxsw_sp_port_vport_find(mlxsw_sp_port, 1);
+	if (WARN_ON(!mlxsw_sp_vport))
+		return;
+
+	mlxsw_sp_vport->lagged = 0;
+}
+
 static int mlxsw_sp_port_lag_join(struct mlxsw_sp_port *mlxsw_sp_port,
 				  struct net_device *lag_dev)
 {
@@ -2830,6 +2856,9 @@ static int mlxsw_sp_port_lag_join(struct mlxsw_sp_port *mlxsw_sp_port,
 	mlxsw_sp_port->lag_id = lag_id;
 	mlxsw_sp_port->lagged = 1;
 	lag->ref_count++;
+
+	mlxsw_sp_port_pvid_vport_lag_join(mlxsw_sp_port, lag_id);
+
 	return 0;
 
 err_col_port_enable:
@@ -2867,6 +2896,8 @@ static void mlxsw_sp_port_lag_leave(struct mlxsw_sp_port *mlxsw_sp_port,
 				     mlxsw_sp_port->local_port);
 	mlxsw_sp_port->lagged = 0;
 	lag->ref_count--;
+
+	mlxsw_sp_port_pvid_vport_lag_leave(mlxsw_sp_port);
 }
 
 static int mlxsw_sp_lag_dist_port_add(struct mlxsw_sp_port *mlxsw_sp_port,
-- 
2.5.5

  parent reply	other threads:[~2016-07-02  7:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-02  7:26 [patch net-next 00/18] mlxsw: Do preparations before ipv4 router offload introduction Jiri Pirko
2016-07-02  7:26 ` [patch net-next 01/18] mlxsw: spectrum: Send untagged packets through a port netdev Jiri Pirko
2016-07-02  7:26 ` [patch net-next 02/18] mlxsw: spectrum: Remove VLANs configuration via SELF flag Jiri Pirko
2016-07-02  7:26 ` Jiri Pirko [this message]
2016-07-02  7:26 ` [patch net-next 04/18] mlxsw: spectrum: Remove RIF from PVID vPort when joining / leaving LAG Jiri Pirko
2016-07-02  7:26 ` [patch net-next 05/18] mlxsw: reg: Add Router General Configuration Register Jiri Pirko
2016-07-02  7:26 ` [patch net-next 06/18] mlxsw: spectrum: Initialize ports at the end of init sequence Jiri Pirko
2016-07-02  7:26 ` [patch net-next 07/18] mlxsw: spectrum_router: Add basic ipv4 router initialization Jiri Pirko
2016-07-02  7:26 ` [patch net-next 08/18] mlxsw: spectrum: Add router interface struct Jiri Pirko
2016-07-02  7:26 ` [patch net-next 09/18] mlxsw: reg: Add FDB action to forward to router Jiri Pirko
2016-07-02  7:26 ` [patch net-next 10/18] mlxsw: reg: Add Router Interface Table Register Jiri Pirko
2016-07-02  7:26 ` [patch net-next 11/18] mlxsw: spectrum: Use action 'discard' when removing traps Jiri Pirko
2016-07-02  7:26 ` [patch net-next 12/18] mlxsw: spectrum: Add traps needed for router implementation Jiri Pirko
2016-07-02  7:26 ` [patch net-next 13/18] mlxsw: spectrum: Add couple of lower device helper functions Jiri Pirko
2016-07-02  7:26 ` [patch net-next 14/18] mlxsw: spectrum: Edit RIF properties based on netdev events Jiri Pirko
2016-07-02  7:26 ` [patch net-next 15/18] mlxsw: spectrum: Introduce support for router interfaces Jiri Pirko
2016-07-02  7:26 ` [patch net-next 16/18] mlxsw: spectrum: Unsplit the vFID range Jiri Pirko
2016-07-02  7:26 ` [patch net-next 17/18] mlxsw: spectrum: Configure FIDs based on bridge events Jiri Pirko
2016-07-02  7:26 ` [patch net-next 18/18] mlxsw: spectrum: Enable L3 interfaces on top of bridge devices Jiri Pirko
2016-07-02  8:37 ` [patch net-next 00/18] mlxsw: Do preparations before ipv4 router offload introduction Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467444400-9480-4-git-send-email-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=eladr@mellanox.com \
    --cc=idosch@mellanox.com \
    --cc=ivecera@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=nogahf@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=sfeldma@gmail.com \
    --cc=tgraf@suug.ch \
    --cc=yotamg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).