netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] lpc_eth: remove unused variable
@ 2016-07-04 13:19 Arnd Bergmann
  2016-07-04 15:50 ` Sylvain Lemieux
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-07-04 13:19 UTC (permalink / raw)
  Cc: Arnd Bergmann, Vladimir Zapolskiy, Sylvain Lemieux,
	David S. Miller, Andrew Lunn, Philippe Reynes, linux-arm-kernel,
	netdev, linux-kernel

A cleanup patch removed the only user of a local variable, as
indicated by a gcc warning.

drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_eth_ioctl':
drivers/net/ethernet/nxp/lpc_eth.c:1183:24: error: unused variable 'pldat' [-Werror=unused-variable]

This removes the variable as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: f786f3564c4f ("net: ethernet: lpc_eth: use phydev from struct net_device")
---
 drivers/net/ethernet/nxp/lpc_eth.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
index ad5464fa8ac7..660d113f8b9a 100644
--- a/drivers/net/ethernet/nxp/lpc_eth.c
+++ b/drivers/net/ethernet/nxp/lpc_eth.c
@@ -1180,7 +1180,6 @@ static void lpc_eth_set_multicast_list(struct net_device *ndev)
 
 static int lpc_eth_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
 {
-	struct netdata_local *pldat = netdev_priv(ndev);
 	struct phy_device *phydev = ndev->phydev;
 
 	if (!netif_running(ndev))
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] lpc_eth: remove unused variable
  2016-07-04 13:19 [PATCH net-next] lpc_eth: remove unused variable Arnd Bergmann
@ 2016-07-04 15:50 ` Sylvain Lemieux
  0 siblings, 0 replies; 2+ messages in thread
From: Sylvain Lemieux @ 2016-07-04 15:50 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Vladimir Zapolskiy, David S. Miller, Andrew Lunn, Philippe Reynes,
	linux-arm-kernel, netdev, linux-kernel

On Mon, 2016-07-04 at 15:19 +0200, Arnd Bergmann wrote:
> A cleanup patch removed the only user of a local variable, as
> indicated by a gcc warning.
> 
> drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_eth_ioctl':
> drivers/net/ethernet/nxp/lpc_eth.c:1183:24: error: unused variable 'pldat' [-Werror=unused-variable]
> 
> This removes the variable as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f786f3564c4f ("net: ethernet: lpc_eth: use phydev from struct net_device")
> ---
>  drivers/net/ethernet/nxp/lpc_eth.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
> index ad5464fa8ac7..660d113f8b9a 100644
> --- a/drivers/net/ethernet/nxp/lpc_eth.c
> +++ b/drivers/net/ethernet/nxp/lpc_eth.c
> @@ -1180,7 +1180,6 @@ static void lpc_eth_set_multicast_list(struct net_device *ndev)
>  
>  static int lpc_eth_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
>  {
> -	struct netdata_local *pldat = netdev_priv(ndev);
>  	struct phy_device *phydev = ndev->phydev;
>  
>  	if (!netif_running(ndev))

Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-04 15:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-04 13:19 [PATCH net-next] lpc_eth: remove unused variable Arnd Bergmann
2016-07-04 15:50 ` Sylvain Lemieux

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).