From: Linus Walleij <linus.walleij@linaro.org>
To: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Steve Glendinning <steve.glendinning@smsc.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jeremy Linton <jeremy.linton@arm.com>,
Kamlakant Patel <kamlakant.patel@broadcom.com>,
Pavel Fedin <p.fedin@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 2/3] net: smsc911x: request and deassert optional RESET GPIO
Date: Fri, 8 Jul 2016 11:07:31 +0200 [thread overview]
Message-ID: <1467968852-6175-2-git-send-email-linus.walleij@linaro.org> (raw)
In-Reply-To: <1467968852-6175-1-git-send-email-linus.walleij@linaro.org>
On some systems (such as the Qualcomm APQ8060 Dragonboard) the
RESET signal of the SMSC911x is not pulled up by a resistor but
connected to a GPIO line, so that the operating system must
explicitly deassert RESET before use.
Support this in the SMSC911x driver so this ethernet connector
can be used on such targets.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/net/ethernet/smsc/smsc911x.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 8af25563f627..125d58ac22bd 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -62,6 +62,7 @@
#include <linux/acpi.h>
#include <linux/pm_runtime.h>
#include <linux/property.h>
+#include <linux/gpio/consumer.h>
#include "smsc911x.h"
@@ -149,6 +150,9 @@ struct smsc911x_data {
/* regulators */
struct regulator_bulk_data supplies[SMSC911X_NUM_SUPPLIES];
+ /* Reset GPIO */
+ struct gpio_desc *reset_gpiod;
+
/* clock */
struct clk *clk;
};
@@ -440,6 +444,15 @@ static int smsc911x_request_resources(struct platform_device *pdev)
netdev_err(ndev, "couldn't get regulators %d\n",
ret);
+ /* Request optional RESET GPIO */
+ pdata->reset_gpiod = devm_gpiod_get(&pdev->dev, "reset",
+ GPIOD_OUT_HIGH);
+ /* Deassert the signal */
+ if (!IS_ERR(pdata->reset_gpiod)) {
+ dev_info(&pdev->dev, "release reset\n");
+ gpiod_set_value(pdata->reset_gpiod, 0);
+ }
+
/* Request clock */
pdata->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(pdata->clk))
--
2.7.4
next prev parent reply other threads:[~2016-07-08 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 9:07 [PATCH 1/3] net: smsc911x: augment device tree bindings Linus Walleij
2016-07-08 9:07 ` Linus Walleij [this message]
2016-07-08 13:52 ` [PATCH 2/3] net: smsc911x: request and deassert optional RESET GPIO Guenter Roeck
2016-07-08 9:07 ` [PATCH 3/3] RFC: net: smsc911x: add wake-up event interrupt support Linus Walleij
2016-07-11 8:14 ` Tony Lindgren
2016-07-11 10:23 ` Sudeep Holla
2016-07-15 19:13 ` Florian Fainelli
2016-07-15 19:03 ` [PATCH 1/3] net: smsc911x: augment device tree bindings Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467968852-6175-2-git-send-email-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=davem@davemloft.net \
--cc=jeremy.linton@arm.com \
--cc=kamlakant.patel@broadcom.com \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=p.fedin@samsung.com \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).