From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support Date: Thu, 14 Jul 2016 16:46:30 +0200 Message-ID: <1468507590.2260.49.camel@pengutronix.de> References: <1468506583-27299-1-git-send-email-p.zabel@pengutronix.de> <7346758.UKW3x0KYDY@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland , Florian Fainelli , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sergei Shtylyov , Geert Uytterhoeven To: Arnd Bergmann Return-path: In-Reply-To: <7346758.UKW3x0KYDY@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Am Donnerstag, den 14.07.2016, 16:33 +0200 schrieb Arnd Bergmann: > On Thursday, July 14, 2016 4:29:43 PM CEST Philipp Zabel wrote: > > + > > + - micrel,fiber-mode: If present the PHY is configured to operate in fiber mode > > + > > + Some PHYs, such as the KSZ8041FTL variant, support fiber mode, enabled > > + by the FXEN boot strapping pin. It can't be determined from the PHY > > + registers whether the PHY is in fiber mode, so this boolean device tree > > + property can be used to describe it. > > + > > + In fiber mode, auto-negotiation is disabled and the PHY can only work in > > + 100base-fx (full and half duplex) modes. > > > > Could the generic "phy-mode" property used for this, to avoid the need for > definingn a custom property? According to ethernet.txt, that property currently describes the internal interface: - phy-mode: string, operation mode of the PHY interface; supported values are "mii", "gmii", "sgmii", "qsgmii", "tbi", "rev-mii", "rmii", "rgmii", "rgmii-id", "rgmii-rxid", "rgmii-txid", "rtbi", "smii", "xgmii"; this is now a de-facto standard property; In this case I have a phy-mode = "rmii" on the MAC. Wouldn't setting phy-mode = "fiber" on the phy be confusing since for the internal interface it should be "rmii"? regards Philipp -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html