[iproute PATCH] ip-macsec.8: fix typo in 'examples' section

[iproute PATCH] ip-macsec.8: fix typo in 'examples' section

[Davide Caratti]

fix wrong 'device' keyword in 'ip link add device eth0'

Signed-off-by: Davide Caratti <dcaratti@redhat.com>
---
 man/man8/ip-macsec.8 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/man8/ip-macsec.8 b/man/man8/ip-macsec.8
index e8455d7..03ed700 100644
--- a/man/man8/ip-macsec.8
+++ b/man/man8/ip-macsec.8
@@ -74,7 +74,7 @@ type.
 .PP
 .SS Create a MACsec device on link eth0
 .nf
-# ip link add device eth0 macsec0 type macsec port 11 encrypt on
+# ip link add link eth0 macsec0 type macsec port 11 encrypt on
 .PP
 .SS Configure a secure association on that device
 .nf
-- 
2.5.5

[iproute PATCH v2] ip-macsec.8: fix typo in 'examples' section

[Davide Caratti]

fix wrong 'device' keyword in 'ip link add device eth0'

changes since v1:
while at it, add missing description of 'validate' keyword and remove
spurious bracket near 'encrypt' keyword. Also, wrong 'es' and 'encoding'
keywords in MACsec section of ip-link.8 have been fixed.

Signed-off-by: Davide Caratti <dcaratti@redhat.com>
---
 man/man8/ip-link.8.in | 8 ++++----
 man/man8/ip-macsec.8  | 5 +++--
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index ad18f75..edb00ff 100644
--- a/man/man8/ip-link.8.in
+++ b/man/man8/ip-link.8.in
@@ -910,14 +910,14 @@ the following additional arguments are supported:
 .BR encrypt " {"
 .BR on " | " off " } ] [ "
 .BR send_sci " { " on " | " off " } ] ["
-.BR es " { " on " | " off " } ] ["
+.BR end_station " { " on " | " off " } ] ["
 .BR scb " { " on " | " off " } ] ["
 .BR protect " { " on " | " off " } ] ["
 .BR replay " { " on " | " off " }"
 .BR window " { "
 .IR 0..2^32-1 " } ] ["
 .BR validate " { " strict " | " check " | " disabled " } ] ["
-.BR encoding " { "
+.BR encodingsa " { "
 .IR 0..3 " } ]"
 
 .in +8
@@ -942,7 +942,7 @@ the following additional arguments are supported:
 - specifies whether the SCI is included in every packet, or only when it is necessary.
 
 .sp
-.BR "es on " or " es off"
+.BR "end_station on " or " end_station off"
 - sets the End Station bit.
 
 .sp
@@ -970,7 +970,7 @@ the following additional arguments are supported:
 - sets the validation mode on the device.
 
 .sp
-.BI encoding " AN "
+.BI encodingsa " AN "
 - sets the active secure association for transmission.
 
 .in -8
diff --git a/man/man8/ip-macsec.8 b/man/man8/ip-macsec.8
index e8455d7..761e4de 100644
--- a/man/man8/ip-macsec.8
+++ b/man/man8/ip-macsec.8
@@ -6,7 +6,7 @@ ip-macsec \- MACsec device configuration
 [ [
 .BR cipher " { " default " | " gcm-aes-128 " } ] "
 .BI icvlen " ICVLEN"
-] [ [
+] [
 .BR encrypt " { " on " | " off " } ] ["
 .BR send_sci " { " on " | " off " } ] ["
 .BR end_station " { " on " | " off " } ] ["
@@ -15,6 +15,7 @@ ip-macsec \- MACsec device configuration
 .BR replay " { " on " | " off " } ] ["
 .BI window " WINDOW"
 ] [
+.BR validate " { " strict " | " check " | " disabled " } ] ["
 .BI encodingsa " SA"
 ]
 
@@ -74,7 +75,7 @@ type.
 .PP
 .SS Create a MACsec device on link eth0
 .nf
-# ip link add device eth0 macsec0 type macsec port 11 encrypt on
+# ip link add link eth0 macsec0 type macsec port 11 encrypt on
 .PP
 .SS Configure a secure association on that device
 .nf
-- 
2.5.5

Re: [iproute PATCH v2] ip-macsec.8: fix typo in 'examples' section

[Davide Caratti]

On Tue, 2016-07-12 at 17:28 +0200, Davide Caratti wrote:
> fix wrong 'device' keyword in 'ip link add device eth0'
> 
> changes since v1:
> while at it, add missing description of 'validate' keyword and remove
> spurious bracket near 'encrypt' keyword. Also, wrong 'es' and 'encoding'
> keywords in MACsec section of ip-link.8 have been fixed.
> 
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>

please drop this patch: I see that some other changes in this area are needed,
so I'm going to repost this - together with the rest of the work - as a series,
in order to avoid overhead.

thank you in advance,
regards,