From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Laight <David.Laight@ACULAB.COM>,
"'Gavin Shan'" <gwshan@linux.vnet.ibm.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"joel@jms.id.au" <joel@jms.id.au>,
"gerlitz.or@gmail.com" <gerlitz.or@gmail.com>,
"weixue@trustnetic.com" <weixue@trustnetic.com>,
"yuvali@mellanox.com" <yuvali@mellanox.com>,
"alexei.starovoitov@gmail.com" <alexei.starovoitov@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next v2 07/10] net/faraday: Read MAC address from chip
Date: Tue, 19 Jul 2016 20:57:53 +1000 [thread overview]
Message-ID: <1468925873.8568.47.camel@kernel.crashing.org> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D5F4FC97F@AcuExch.aculab.com>
On Tue, 2016-07-19 at 10:50 +0000, David Laight wrote:
> > + if (!is_valid_ether_addr(mac)) {
> > + mac[5] = (m >> 8) & 0xff;
> > + mac[4] = m & 0xff;
> > + mac[3] = (l >> 24) & 0xff;
> > + mac[2] = (l >> 16) & 0xff;
> > + mac[1] = (l >> 8) & 0xff;
> > + mac[0] = l & 0xff;
> > + }
> ...
>
> That is horrid, not all byte reversed addresses will be invalid.
Right, that's just a hack for a broken vendor uboot we had here, Gavin,
drop that part of the patch please.
Cheers,
Ben.
next prev parent reply other threads:[~2016-07-19 10:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 10:44 [PATCH net-next v2 00/10] NCSI Support Gavin Shan
2016-07-15 10:44 ` [PATCH net-next v2 01/10] net/ncsi: Resource management Gavin Shan
2016-07-15 10:44 ` [PATCH net-next v2 02/10] net/ncsi: NCSI command packet handler Gavin Shan
2016-07-15 14:08 ` kbuild test robot
2016-07-18 0:15 ` Gavin Shan
2016-07-19 1:48 ` Gavin Shan
2016-07-15 10:44 ` [PATCH net-next v2 03/10] net/ncsi: NCSI response " Gavin Shan
2016-07-15 10:44 ` [PATCH net-next v2 04/10] net/ncsi: Package and channel management Gavin Shan
2016-07-15 14:30 ` kbuild test robot
2016-07-18 0:16 ` Gavin Shan
2016-07-15 10:44 ` [PATCH net-next v2 05/10] net/ncsi: NCSI AEN packet handler Gavin Shan
2016-07-15 10:44 ` [PATCH net-next v2 06/10] net/faraday: Helper functions to create or destroy MDIO interface Gavin Shan
2016-07-15 10:44 ` [PATCH net-next v2 07/10] net/faraday: Read MAC address from chip Gavin Shan
2016-07-19 10:50 ` David Laight
2016-07-19 10:57 ` Benjamin Herrenschmidt [this message]
2016-07-19 23:40 ` Gavin Shan
2016-07-15 10:44 ` [PATCH net-next v2 08/10] net/faraday: Support NCSI mode Gavin Shan
2016-07-15 10:44 ` [PATCH net-next v2 09/10] net/faraday: Match driver according to compatible property Gavin Shan
2016-07-15 10:44 ` [PATCH net-next v2 10/10] net/faraday: Mask PHY interrupt with NCSI mode Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468925873.8568.47.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=David.Laight@ACULAB.COM \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gerlitz.or@gmail.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=netdev@vger.kernel.org \
--cc=weixue@trustnetic.com \
--cc=yuvali@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).