netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: zyjzyj2000@gmail.com
To: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,
	netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Cc: Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: [PATCH 1/1] ixgbevf: replace num with macro
Date: Wed, 20 Jul 2016 12:36:41 +0800	[thread overview]
Message-ID: <1468989401-28529-1-git-send-email-zyjzyj2000@gmail.com> (raw)

From: Zhu Yanjun <zyjzyj2000@gmail.com>

With the original num, when a several bits state is set, it is
possible that the wrong test occurs.

For example,

a state is 0x3, its bits are 11. When testing a state 0x2 whose
bits are 10, it is difficult to confirm that state 0x2 is set or
not.

As such, the MACROs are defined to avoid the above error.

Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
index 60fc63b..d37b910 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
@@ -436,18 +436,16 @@ struct ixgbevf_adapter {
 	u8 rss_indir_tbl[IXGBEVF_X550_VFRETA_SIZE];
 };
 
-enum ixbgevf_state_t {
-	__IXGBEVF_TESTING,
-	__IXGBEVF_RESETTING,
-	__IXGBEVF_DOWN,
-	__IXGBEVF_DISABLED,
-	__IXGBEVF_REMOVING,
-	__IXGBEVF_SERVICE_SCHED,
-	__IXGBEVF_SERVICE_INITED,
-	__IXGBEVF_RESET_REQUESTED,
-	__IXGBEVF_QUEUE_RESET_REQUESTED,
-	__IXGBEVF_HW_RESETTING,
-};
+#define	__IXGBEVF_TESTING		0x0001
+#define	__IXGBEVF_RESETTING		0x0002
+#define	__IXGBEVF_DOWN			0x0004
+#define	__IXGBEVF_DISABLED		0x0008
+#define	__IXGBEVF_REMOVING		0x0010
+#define	__IXGBEVF_SERVICE_SCHED		0x0020
+#define	__IXGBEVF_SERVICE_INITED	0x0040
+#define	__IXGBEVF_RESET_REQUESTED	0x0080
+#define	__IXGBEVF_QUEUE_RESET_REQUESTED	0x0100
+#define	__IXGBEVF_HW_RESETTING		0x0200
 
 enum ixgbevf_boards {
 	board_82599_vf,
-- 
2.7.4

                 reply	other threads:[~2016-07-20  4:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468989401-28529-1-git-send-email-zyjzyj2000@gmail.com \
    --to=zyjzyj2000@gmail.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).