From: Vegard Nossum <vegard.nossum@oracle.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Vegard Nossum <vegard.nossum@oracle.com>
Subject: [PATCH] xfrm: use printk instead of WARN for bad policy reporting
Date: Wed, 20 Jul 2016 10:32:35 +0200 [thread overview]
Message-ID: <1469003555-30599-1-git-send-email-vegard.nossum@oracle.com> (raw)
AFAICT this message is just printed whenever input validation fails.
This is a normal failure and we shouldn't be dumping the stack over it.
Looks like it was originally a printk that was maybe incorrectly
upgraded to a WARN:
commit 62db5cfd70b1ef53aa21f144a806fe3b78c84fab
Author: stephen hemminger <shemminger@vyatta.com>
Date: Wed May 12 06:37:06 2010 +0000
xfrm: add severity to printk
Cc: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
---
net/xfrm/xfrm_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index 4fb04ce..0b81bfc 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -2150,7 +2150,7 @@ static int xfrm_add_acquire(struct sk_buff *skb, struct nlmsghdr *nlh,
return 0;
bad_policy:
- WARN(1, "BAD policy passed\n");
+ printk(KERN_WARNING "xfrm_user: bad policy passed\n");
free_state:
kfree(x);
nomem:
--
1.9.1
next reply other threads:[~2016-07-20 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 8:32 Vegard Nossum [this message]
2016-07-20 11:53 ` [PATCH] xfrm: use printk instead of WARN for bad policy reporting Vegard Nossum
2016-07-27 3:01 ` Herbert Xu
2016-07-27 6:20 ` Vegard Nossum
2016-07-27 6:31 ` Herbert Xu
2016-07-27 6:44 ` Vegard Nossum
2016-07-28 4:58 ` Steffen Klassert
2016-07-20 12:15 ` Steffen Klassert
2016-07-27 6:03 ` Vegard Nossum
2016-07-28 4:57 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469003555-30599-1-git-send-email-vegard.nossum@oracle.com \
--to=vegard.nossum@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).