From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vegard Nossum Subject: [PATCH] xfrm: use printk instead of WARN for bad policy reporting Date: Wed, 20 Jul 2016 10:32:35 +0200 Message-ID: <1469003555-30599-1-git-send-email-vegard.nossum@oracle.com> Cc: netdev@vger.kernel.org, Vegard Nossum To: Stephen Hemminger Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:38916 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753070AbcGTIfQ (ORCPT ); Wed, 20 Jul 2016 04:35:16 -0400 Sender: netdev-owner@vger.kernel.org List-ID: AFAICT this message is just printed whenever input validation fails. This is a normal failure and we shouldn't be dumping the stack over it. Looks like it was originally a printk that was maybe incorrectly upgraded to a WARN: commit 62db5cfd70b1ef53aa21f144a806fe3b78c84fab Author: stephen hemminger Date: Wed May 12 06:37:06 2010 +0000 xfrm: add severity to printk Cc: Stephen Hemminger Signed-off-by: Vegard Nossum --- net/xfrm/xfrm_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 4fb04ce..0b81bfc 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -2150,7 +2150,7 @@ static int xfrm_add_acquire(struct sk_buff *skb, struct nlmsghdr *nlh, return 0; bad_policy: - WARN(1, "BAD policy passed\n"); + printk(KERN_WARNING "xfrm_user: bad policy passed\n"); free_state: kfree(x); nomem: -- 1.9.1