From: Joe Perches <joe@perches.com>
To: Michael Chan <michael.chan@broadcom.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] bnxt_en: Log a message, if enabling NTUPLE filtering fails.
Date: Mon, 25 Jul 2016 07:00:44 -0700 [thread overview]
Message-ID: <1469455244.1900.178.camel@perches.com> (raw)
In-Reply-To: <1469416917-29659-3-git-send-email-michael.chan@broadcom.com>
On Sun, 2016-07-24 at 23:21 -0400, Michael Chan wrote:
> If there are not enough resources to enable ntuple filtering,
> log a warning message.
[]
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
[]
> @@ -5790,8 +5790,14 @@ static bool bnxt_rfs_capable(struct bnxt *bp)
> return false;
>
> vnics = 1 + bp->rx_nr_rings;
> - if (vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics)
> + if (vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics) {
> + netdev_warn(bp->dev,
> + "Not enough resources to support NTUPLE filters");
> + netdev_warn(bp->dev,
> + "Enough NTUPLE resources for up to %d rx rings",
Missing newline terminations and may be better as a single message
next prev parent reply other threads:[~2016-07-25 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 3:21 [PATCH net-next 0/3] bnxt_en: Improve ntuple filters and add new IDs Michael Chan
2016-07-25 3:21 ` [PATCH net-next 1/3] bnxt_en: Improve ntuple filters by checking destination MAC address Michael Chan
2016-07-25 3:21 ` [PATCH net-next 2/3] bnxt_en: Log a message, if enabling NTUPLE filtering fails Michael Chan
2016-07-25 14:00 ` Joe Perches [this message]
2016-07-25 3:21 ` [PATCH net-next 3/3] bnxt_en: Add new NPAR and dual media device IDs Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469455244.1900.178.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).