From: Peter Chen <peter.chen@nxp.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <vbridger@opensource.altera.com>,
<isubramanian@apm.com>, <kchudgar@apm.com>,
<yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
<thomas.petazzoni@free-electrons.com>,
<sergei.shtylyov@cogentembedded.com>, <peppe.cavallaro@st.com>,
<alexandre.torgue@st.com>, <mugunthanvnm@ti.com>,
<tremyfr@gmail.com>, <wxt@rock-chips.com>, <arnd@arndb.de>,
<david.daney@cavium.com>, <huangdaode@hisilicon.com>,
<jszhang@marvell.com>, Peter Chen <peter.chen@nxp.com>
Subject: [PATCH 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: add missing of_node_put after calling of_parse_phandle
Date: Wed, 27 Jul 2016 10:20:39 +0800 [thread overview]
Message-ID: <1469586048-15697-7-git-send-email-peter.chen@nxp.com> (raw)
In-Reply-To: <1469586048-15697-1-git-send-email-peter.chen@nxp.com>
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
index 3fb87e2..18d72ea 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
@@ -786,6 +786,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb)
np = of_parse_phandle(mac_cb->dev->of_node, "phy-handle",
mac_cb->mac_id);
mac_cb->phy_dev = of_phy_find_device(np);
+ of_node_put(np);
if (mac_cb->phy_dev) {
/* refcount is held by of_phy_find_device()
* if the phy_dev is found
@@ -804,6 +805,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb)
np = of_parse_phandle(to_of_node(mac_cb->fw_port),
"phy-handle", 0);
mac_cb->phy_dev = of_phy_find_device(np);
+ of_node_put(np);
if (mac_cb->phy_dev) {
/* refcount is held by of_phy_find_device()
* if the phy_dev is found
@@ -813,9 +815,10 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb)
mac_cb->mac_id, np->name);
}
- syscon = syscon_node_to_regmap(
- of_parse_phandle(to_of_node(mac_cb->fw_port),
- "serdes-syscon", 0));
+ np = of_parse_phandle(to_of_node(mac_cb->fw_port),
+ "serdes-syscon", 0);
+ syscon = syscon_node_to_regmap(np);
+ of_node_put(np);
if (IS_ERR_OR_NULL(syscon)) {
dev_err(mac_cb->dev, "serdes-syscon is needed!\n");
return -EINVAL;
--
1.9.1
next prev parent reply other threads:[~2016-07-27 2:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 2:20 [PATCH 00/15] ethernet: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-27 2:20 ` [PATCH 01/15] ethernet: altera: add missing of_node_put Peter Chen
2016-07-27 2:20 ` [PATCH 02/15] ethernet: apm: xgene: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-27 2:20 ` [PATCH 03/15] ethernet: arc: emac_main: " Peter Chen
2016-07-27 2:20 ` [PATCH 04/15] ethernet: aurora: nb8800: " Peter Chen
2016-07-30 6:13 ` David Miller
2016-08-01 1:19 ` Peter Chen
2016-07-27 2:20 ` [PATCH 05/15] ethernet: cavium: octeon: " Peter Chen
2016-07-27 20:56 ` David Daney
2016-07-28 1:57 ` Peter Chen
2016-07-27 2:20 ` Peter Chen [this message]
2016-07-28 0:38 ` [PATCH 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: " Yisen Zhuang
2016-07-28 3:43 ` Peter Chen
2016-07-27 2:20 ` [PATCH 07/15] ethernet: hisilicon: hns: hns_dsaf_main: " Peter Chen
2016-07-27 2:20 ` [PATCH 08/15] ethernet: marvell: mvneta: " Peter Chen
2016-07-27 2:20 ` [PATCH 09/15] ethernet: marvell: mvpp2: " Peter Chen
2016-07-27 2:20 ` [PATCH 10/15] ethernet: marvell: pxa168_eth: " Peter Chen
2016-07-27 2:20 ` [PATCH 11/15] ethernet: renesas: ravb_main: " Peter Chen
2016-07-27 10:50 ` Sergei Shtylyov
2016-07-27 2:20 ` [PATCH 12/15] ethernet: renesas: sh_eth: " Peter Chen
2016-07-27 10:51 ` Sergei Shtylyov
2016-07-27 2:20 ` [PATCH 13/15] ethernet: stmicro: stmmac: dwmac-socfpga: " Peter Chen
2016-07-27 2:20 ` [PATCH 14/15] ethernet: stmicro: stmmac: stmmac_platform: " Peter Chen
2016-07-28 7:39 ` Alexandre Torgue
2016-07-28 9:30 ` Peter Chen
2016-08-01 6:50 ` Peter Chen
2016-07-27 2:20 ` [PATCH 15/15] ethernet: ti: davinci_emac: " Peter Chen
2016-07-27 5:45 ` Mugunthan V N
2016-07-27 7:43 ` Peter Chen
2016-07-29 9:29 ` Mugunthan V N
2016-08-01 1:21 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469586048-15697-7-git-send-email-peter.chen@nxp.com \
--to=peter.chen@nxp.com \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=huangdaode@hisilicon.com \
--cc=isubramanian@apm.com \
--cc=jszhang@marvell.com \
--cc=kchudgar@apm.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=salil.mehta@huawei.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tremyfr@gmail.com \
--cc=vbridger@opensource.altera.com \
--cc=wxt@rock-chips.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).