From: Peter Chen <peter.chen@nxp.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <vbridger@opensource.altera.com>,
<isubramanian@apm.com>, <kchudgar@apm.com>,
<yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
<thomas.petazzoni@free-electrons.com>,
<sergei.shtylyov@cogentembedded.com>, <peppe.cavallaro@st.com>,
<alexandre.torgue@st.com>, <mugunthanvnm@ti.com>,
<tremyfr@gmail.com>, <wxt@rock-chips.com>, <arnd@arndb.de>,
<david.daney@cavium.com>, <huangdaode@hisilicon.com>,
<jszhang@marvell.com>, Peter Chen <peter.chen@nxp.com>
Subject: [PATCH v2 05/15] ethernet: cavium: octeon: add missing of_node_put after calling of_parse_phandle
Date: Mon, 1 Aug 2016 15:02:33 +0800 [thread overview]
Message-ID: <1470034963-30506-6-git-send-email-peter.chen@nxp.com> (raw)
In-Reply-To: <1470034963-30506-1-git-send-email-peter.chen@nxp.com>
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
index e8bc15b..4ab404f 100644
--- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
+++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
@@ -1513,6 +1513,7 @@ static int octeon_mgmt_probe(struct platform_device *pdev)
return 0;
err:
+ of_node_put(p->phy_np);
free_netdev(netdev);
return result;
}
@@ -1520,8 +1521,10 @@ err:
static int octeon_mgmt_remove(struct platform_device *pdev)
{
struct net_device *netdev = platform_get_drvdata(pdev);
+ struct octeon_mgmt *p = netdev_priv(netdev);
unregister_netdev(netdev);
+ of_node_put(p->phy_np);
free_netdev(netdev);
return 0;
}
--
1.9.1
next prev parent reply other threads:[~2016-08-01 7:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 7:02 [PATCH v2 00/15] add missing of_node_put after calling of_parse_phandle Peter Chen
2016-08-01 7:02 ` [PATCH v2 01/15] ethernet: altera: add missing of_node_put Peter Chen
2016-08-01 7:02 ` [PATCH v2 02/15] ethernet: apm: xgene: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-08-01 7:02 ` [PATCH v2 03/15] ethernet: arc: emac_main: " Peter Chen
2016-08-01 7:02 ` [PATCH v2 04/15] ethernet: aurora: nb8800: " Peter Chen
2016-08-01 7:02 ` Peter Chen [this message]
2016-08-01 7:02 ` [PATCH v2 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: " Peter Chen
2016-08-01 7:02 ` [PATCH v2 07/15] ethernet: hisilicon: hns: hns_dsaf_main: " Peter Chen
2016-08-01 7:02 ` [PATCH v2 08/15] ethernet: marvell: mvneta: " Peter Chen
2016-08-01 7:02 ` [PATCH v2 09/15] ethernet: marvell: mvpp2: " Peter Chen
2016-08-01 7:02 ` [PATCH v2 10/15] ethernet: marvell: pxa168_eth: " Peter Chen
2016-08-01 7:02 ` [PATCH v2 11/15] ethernet: renesas: ravb_main: " Peter Chen
2016-08-01 7:02 ` [PATCH v2 12/15] ethernet: renesas: sh_eth: " Peter Chen
2016-08-01 7:02 ` [PATCH v2 13/15] ethernet: stmicro: stmmac: dwmac-socfpga: " Peter Chen
2016-08-01 7:02 ` [PATCH v2 14/15] ethernet: stmicro: stmmac: " Peter Chen
2016-08-01 7:37 ` Alexandre Torgue
2016-08-01 7:02 ` [PATCH v2 15/15] ethernet: ti: davinci_emac: " Peter Chen
2016-08-01 8:28 ` Mugunthan V N
2016-08-02 5:14 ` [PATCH v2 00/15] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470034963-30506-6-git-send-email-peter.chen@nxp.com \
--to=peter.chen@nxp.com \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=huangdaode@hisilicon.com \
--cc=isubramanian@apm.com \
--cc=jszhang@marvell.com \
--cc=kchudgar@apm.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=salil.mehta@huawei.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tremyfr@gmail.com \
--cc=vbridger@opensource.altera.com \
--cc=wxt@rock-chips.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).