* [PATCH] net: arc_emac: add missing of_node_put() in arc_emac_probe()
@ 2016-08-03 10:58 Wei Yongjun
2016-08-04 6:20 ` Peter Chen
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-08-03 10:58 UTC (permalink / raw)
To: David S . Miller, Alexander Kochetkov, Philippe Reynes,
Peter Chen, Caesar Wang
Cc: Wei Yongjun, netdev
commit a94efbd7cc45 ("ethernet: arc: emac_main: add missing of_node_put
after calling of_parse_phandle") added missing of_node_put after calling
of_parse_phandle, but missing the devm_ioremap_resource() error handling
case.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/net/ethernet/arc/emac_main.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c
index 4bff0f3..b0da969 100644
--- a/drivers/net/ethernet/arc/emac_main.c
+++ b/drivers/net/ethernet/arc/emac_main.c
@@ -771,8 +771,10 @@ int arc_emac_probe(struct net_device *ndev, int interface)
priv->dev = dev;
priv->regs = devm_ioremap_resource(dev, &res_regs);
- if (IS_ERR(priv->regs))
- return PTR_ERR(priv->regs);
+ if (IS_ERR(priv->regs)) {
+ err = PTR_ERR(priv->regs);
+ goto out_put_node;
+ }
dev_dbg(dev, "Registers base address is 0x%p\n", priv->regs);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] net: arc_emac: add missing of_node_put() in arc_emac_probe()
2016-08-03 10:58 [PATCH] net: arc_emac: add missing of_node_put() in arc_emac_probe() Wei Yongjun
@ 2016-08-04 6:20 ` Peter Chen
0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2016-08-04 6:20 UTC (permalink / raw)
To: Wei Yongjun, David S . Miller, Alexander Kochetkov,
Philippe Reynes, Caesar Wang
Cc: netdev@vger.kernel.org
>
>Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>---
> drivers/net/ethernet/arc/emac_main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ethernet/arc/emac_main.c
>b/drivers/net/ethernet/arc/emac_main.c
>index 4bff0f3..b0da969 100644
>--- a/drivers/net/ethernet/arc/emac_main.c
>+++ b/drivers/net/ethernet/arc/emac_main.c
>@@ -771,8 +771,10 @@ int arc_emac_probe(struct net_device *ndev, int interface)
> priv->dev = dev;
>
> priv->regs = devm_ioremap_resource(dev, &res_regs);
>- if (IS_ERR(priv->regs))
>- return PTR_ERR(priv->regs);
>+ if (IS_ERR(priv->regs)) {
>+ err = PTR_ERR(priv->regs);
>+ goto out_put_node;
>+ }
>
> dev_dbg(dev, "Registers base address is 0x%p\n", priv->regs);
Thanks, I missed that error path.
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Peter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-04 6:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-03 10:58 [PATCH] net: arc_emac: add missing of_node_put() in arc_emac_probe() Wei Yongjun
2016-08-04 6:20 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).