* [PATCH 00/11] use of_property_read_bool
@ 2016-08-05 8:56 Julia Lawall
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
0 siblings, 1 reply; 11+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: netdev
Cc: alsa-devel, kernel-janitors, linux-usb, linux-mmc, linux-kernel,
linux-gpio, linux-i2c, linux-serial, linuxppc-dev,
linux-arm-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
---
arch/powerpc/sysdev/mpic.c | 2 +-
drivers/i2c/busses/i2c-mpc.c | 2 +-
drivers/mmc/host/sdhci-of-esdhc.c | 2 +-
drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
drivers/phy/phy-qcom-ufs.c | 2 +-
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 2 +-
drivers/soc/fsl/qe/qe_tdm.c | 2 +-
drivers/soc/ti/knav_qmss_queue.c | 2 +-
drivers/tty/serial/atmel_serial.c | 8 ++++----
drivers/usb/host/fsl-mph-dr-of.c | 6 +++---
sound/soc/codecs/ab8500-codec.c | 10 +++++-----
sound/soc/sh/rcar/ssi.c | 2 +-
sound/soc/soc-core.c | 2 +-
13 files changed, 22 insertions(+), 23 deletions(-)
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2016-08-05 9:30 ` Johannes Berg
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: netdev; +Cc: kernel-janitors, linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 7b8fe86..a77ba98 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
goto err_ioremap;
}
- if (of_get_property(pdev->dev.of_node,
- "little-endian", NULL))
+ if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
priv->is_little_endian = true;
else
priv->is_little_endian = false;
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
@ 2016-08-05 9:30 ` Johannes Berg
2016-08-05 9:47 ` Julia Lawall
2016-08-05 10:08 ` Julia Lawall
2016-08-05 11:24 ` [PATCH 08/11 v2] " Julia Lawall
2016-08-05 11:35 ` [PATCH 08/11] " Sergei Shtylyov
2 siblings, 2 replies; 11+ messages in thread
From: Johannes Berg @ 2016-08-05 9:30 UTC (permalink / raw)
To: Julia Lawall, netdev; +Cc: kernel-janitors, linux-kernel
> - if (of_get_property(pdev->dev.of_node,
> - "little-endian", NULL))
> + if (of_property_read_bool(pdev->dev.of_node, "little-
> endian"))
> priv->is_little_endian = true;
> else
> priv->is_little_endian = false;
>
Perhaps, while changing this, that'd be better as
priv->is_little_endian = of_property_read_bool(...);
Obviously that would've worked before, but now it'd be even easier to
understand, it seems.
johannes
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 9:30 ` Johannes Berg
@ 2016-08-05 9:47 ` Julia Lawall
2016-08-05 10:08 ` Julia Lawall
1 sibling, 0 replies; 11+ messages in thread
From: Julia Lawall @ 2016-08-05 9:47 UTC (permalink / raw)
To: Johannes Berg; +Cc: netdev, kernel-janitors, linux-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 564 bytes --]
On Fri, 5 Aug 2016, Johannes Berg wrote:
>
> > - if (of_get_property(pdev->dev.of_node,
> > - "little-endian", NULL))
> > + if (of_property_read_bool(pdev->dev.of_node, "little-
> > endian"))
> > priv->is_little_endian = true;
> > else
> > priv->is_little_endian = false;
> >
>
> Perhaps, while changing this, that'd be better as
>
> priv->is_little_endian = of_property_read_bool(...);
>
> Obviously that would've worked before, but now it'd be even easier to
> understand, it seems.
Thanks for the suggestion. Will send shortly.
julia
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 9:30 ` Johannes Berg
2016-08-05 9:47 ` Julia Lawall
@ 2016-08-05 10:08 ` Julia Lawall
2016-08-05 10:12 ` Johannes Berg
1 sibling, 1 reply; 11+ messages in thread
From: Julia Lawall @ 2016-08-05 10:08 UTC (permalink / raw)
To: Johannes Berg; +Cc: netdev, kernel-janitors, linux-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 800 bytes --]
On Fri, 5 Aug 2016, Johannes Berg wrote:
>
> > - if (of_get_property(pdev->dev.of_node,
> > - "little-endian", NULL))
> > + if (of_property_read_bool(pdev->dev.of_node, "little-
> > endian"))
> > priv->is_little_endian = true;
> > else
> > priv->is_little_endian = false;
> >
>
> Perhaps, while changing this, that'd be better as
>
> priv->is_little_endian = of_property_read_bool(...);
>
> Obviously that would've worked before, but now it'd be even easier to
> understand, it seems.
Can I do the same for:
if (of_property_read_bool(np, "phy-clk-valid"))
pdata->check_phy_clk_valid = 1;
else
pdata->check_phy_clk_valid = 0;
The type is not bool, but:
include/linux/fsl_devices.h: unsigned check_phy_clk_valid:1;
thanks,
julia
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 10:08 ` Julia Lawall
@ 2016-08-05 10:12 ` Johannes Berg
2016-08-05 10:14 ` Julia Lawall
0 siblings, 1 reply; 11+ messages in thread
From: Johannes Berg @ 2016-08-05 10:12 UTC (permalink / raw)
To: Julia Lawall; +Cc: netdev, kernel-janitors, linux-kernel
On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
>
> Can I do the same for:
>
> if (of_property_read_bool(np, "phy-clk-valid"))
> pdata->check_phy_clk_valid = 1;
> else
> pdata->check_phy_clk_valid = 0;
>
> The type is not bool, but:
>
> include/linux/fsl_devices.h: unsigned check_phy_clk_valid:1;
>
The type doesn't even matter, does it? Any bool->int conversion should
result in 0/1.
johannes
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 10:12 ` Johannes Berg
@ 2016-08-05 10:14 ` Julia Lawall
0 siblings, 0 replies; 11+ messages in thread
From: Julia Lawall @ 2016-08-05 10:14 UTC (permalink / raw)
To: Johannes Berg; +Cc: netdev, kernel-janitors, linux-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 614 bytes --]
On Fri, 5 Aug 2016, Johannes Berg wrote:
> On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
> >
> > Can I do the same for:
> >
> > if (of_property_read_bool(np, "phy-clk-valid"))
> > pdata->check_phy_clk_valid = 1;
> > else
> > pdata->check_phy_clk_valid = 0;
> >
> > The type is not bool, but:
> >
> > include/linux/fsl_devices.h: unsigned check_phy_clk_valid:1;
> >
> The type doesn't even matter, does it? Any bool->int conversion should
> result in 0/1.
Just paranoid. Thanks.
julia
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 08/11 v2] net/fsl: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
2016-08-05 9:30 ` Johannes Berg
@ 2016-08-05 11:24 ` Julia Lawall
2016-08-05 11:35 ` [PATCH 08/11] " Sergei Shtylyov
2 siblings, 0 replies; 11+ messages in thread
From: Julia Lawall @ 2016-08-05 11:24 UTC (permalink / raw)
To: netdev; +Cc: kernel-janitors, linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2,x;
@@
- if (of_get_property(e1,e2,NULL))
- x = true;
- else
- x = false;
+ x = of_property_read_bool(e1,e2);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
v2: special case for propagating true and false
drivers/net/ethernet/freescale/xgmac_mdio.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 7b8fe86..e03b30c 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -271,11 +271,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
goto err_ioremap;
}
- if (of_get_property(pdev->dev.of_node,
- "little-endian", NULL))
- priv->is_little_endian = true;
- else
- priv->is_little_endian = false;
+ priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
+ "little-endian");
ret = of_mdiobus_register(bus, np);
if (ret) {
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
2016-08-05 9:30 ` Johannes Berg
2016-08-05 11:24 ` [PATCH 08/11 v2] " Julia Lawall
@ 2016-08-05 11:35 ` Sergei Shtylyov
2016-08-05 11:38 ` Julia Lawall
2 siblings, 1 reply; 11+ messages in thread
From: Sergei Shtylyov @ 2016-08-05 11:35 UTC (permalink / raw)
To: Julia Lawall, netdev; +Cc: kernel-janitors, linux-kernel
Hello.
On 8/5/2016 11:56 AM, Julia Lawall wrote:
> Use of_property_read_bool to check for the existence of a property.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2;
> statement S2,S1;
> @@
> - if (of_get_property(e1,e2,NULL))
> + if (of_property_read_bool(e1,e2))
> S1 else S2
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
> index 7b8fe86..a77ba98 100644
> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
> @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
> goto err_ioremap;
> }
>
> - if (of_get_property(pdev->dev.of_node,
> - "little-endian", NULL))
> + if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
> priv->is_little_endian = true;
> else
> priv->is_little_endian = false;
priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
"little-endian"));
MBR, Sergei
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 11:35 ` [PATCH 08/11] " Sergei Shtylyov
@ 2016-08-05 11:38 ` Julia Lawall
2016-08-05 11:40 ` Sergei Shtylyov
0 siblings, 1 reply; 11+ messages in thread
From: Julia Lawall @ 2016-08-05 11:38 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev, kernel-janitors, linux-kernel
On Fri, 5 Aug 2016, Sergei Shtylyov wrote:
> Hello.
>
> On 8/5/2016 11:56 AM, Julia Lawall wrote:
>
> > Use of_property_read_bool to check for the existence of a property.
> >
> > The semantic patch that makes this change is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @@
> > expression e1,e2;
> > statement S2,S1;
> > @@
> > - if (of_get_property(e1,e2,NULL))
> > + if (of_property_read_bool(e1,e2))
> > S1 else S2
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> > drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c
> > b/drivers/net/ethernet/freescale/xgmac_mdio.c
> > index 7b8fe86..a77ba98 100644
> > --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
> > +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
> > @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device
> > *pdev)
> > goto err_ioremap;
> > }
> >
> > - if (of_get_property(pdev->dev.of_node,
> > - "little-endian", NULL))
> > + if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
> > priv->is_little_endian = true;
> > else
> > priv->is_little_endian = false;
>
> priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
> "little-endian"));
Thanks,
I just sent a v2 with this change.
julia
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 11:38 ` Julia Lawall
@ 2016-08-05 11:40 ` Sergei Shtylyov
0 siblings, 0 replies; 11+ messages in thread
From: Sergei Shtylyov @ 2016-08-05 11:40 UTC (permalink / raw)
To: Julia Lawall; +Cc: netdev, kernel-janitors, linux-kernel
On 8/5/2016 2:38 PM, Julia Lawall wrote:
>>> Use of_property_read_bool to check for the existence of a property.
>>>
>>> The semantic patch that makes this change is as follows:
>>> (http://coccinelle.lip6.fr/)
>>>
>>> // <smpl>
>>> @@
>>> expression e1,e2;
>>> statement S2,S1;
>>> @@
>>> - if (of_get_property(e1,e2,NULL))
>>> + if (of_property_read_bool(e1,e2))
>>> S1 else S2
>>> // </smpl>
>>>
>>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>>>
>>> ---
>>> drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> b/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> index 7b8fe86..a77ba98 100644
>>> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device
>>> *pdev)
>>> goto err_ioremap;
>>> }
>>>
>>> - if (of_get_property(pdev->dev.of_node,
>>> - "little-endian", NULL))
>>> + if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
>>> priv->is_little_endian = true;
>>> else
>>> priv->is_little_endian = false;
>>
>> priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
>> "little-endian"));
>
> Thanks,
>
> I just sent a v2 with this change.
I've seen. Sorry, forgot to look at the followups before commenting...
> julia
MBR, Sergei
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2016-08-05 11:40 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
2016-08-05 9:30 ` Johannes Berg
2016-08-05 9:47 ` Julia Lawall
2016-08-05 10:08 ` Julia Lawall
2016-08-05 10:12 ` Johannes Berg
2016-08-05 10:14 ` Julia Lawall
2016-08-05 11:24 ` [PATCH 08/11 v2] " Julia Lawall
2016-08-05 11:35 ` [PATCH 08/11] " Sergei Shtylyov
2016-08-05 11:38 ` Julia Lawall
2016-08-05 11:40 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).