From: Phil Sutter <phil@nwl.cc>
To: Stephen Hemminger <shemming@brocade.com>
Cc: netdev@vger.kernel.org
Subject: [iproute PATCH] ip-route: Pretty-print expired routes
Date: Wed, 10 Aug 2016 13:14:50 +0200 [thread overview]
Message-ID: <1470827690-5625-1-git-send-email-phil@nwl.cc> (raw)
Instead of printing 'expires -23sec' for expired (but not yet garbage
collected) routes, print 'expired 23sec' instead.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
ip/iproute.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/ip/iproute.c b/ip/iproute.c
index c52294d298210..a89a26d68be0f 100644
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -305,6 +305,14 @@ static void print_rtax_features(FILE *fp, unsigned int features)
fprintf(fp, " 0x%x", of);
}
+static void print_expires(FILE *fp, __s32 expires, int hz)
+{
+ if (expires > 0)
+ fprintf(fp, " expires %dsec", expires/hz);
+ else
+ fprintf(fp, " expired %dsec", -expires/hz);
+}
+
int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
{
FILE *fp = (FILE *)arg;
@@ -502,7 +510,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
if (!hz)
hz = get_user_hz();
if (ci->rta_expires != 0)
- fprintf(fp, " expires %dsec", ci->rta_expires/hz);
+ print_expires(fp, ci->rta_expires, hz);
if (ci->rta_error != 0)
fprintf(fp, " error %d", ci->rta_error);
if (show_stats) {
@@ -530,7 +538,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
if (r->rtm_flags & RTM_F_CLONED)
fprintf(fp, "%s cache ", _SL_);
if (ci->rta_expires)
- fprintf(fp, " expires %dsec", ci->rta_expires/hz);
+ print_expires(fp, ci->rta_expires, hz);
if (ci->rta_error != 0)
fprintf(fp, " error %d", ci->rta_error);
if (show_stats) {
--
2.8.2
next reply other threads:[~2016-08-10 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 11:14 Phil Sutter [this message]
2016-08-11 13:46 ` [iproute PATCH] ip-route: Pretty-print expired routes Edward Cree
2016-08-11 13:54 ` Phil Sutter
2016-08-12 19:58 ` Stephen Hemminger
2016-08-12 21:11 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470827690-5625-1-git-send-email-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netdev@vger.kernel.org \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).