* [PATCH 1/1] net: i10e: use matching format indentifiers @ 2016-07-31 9:39 Heinrich Schuchardt 2016-08-01 3:47 ` David Miller 0 siblings, 1 reply; 5+ messages in thread From: Heinrich Schuchardt @ 2016-07-31 9:39 UTC (permalink / raw) To: Jeff Kirsher; +Cc: intel-wired-lan, netdev, linux-kernel, Heinrich Schuchardt i is defined as int but output as %u several times. Change the definition to unsigned. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index c912e04..8b08a69 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -1532,7 +1532,7 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset, struct i40e_vsi *vsi = np->vsi; struct i40e_pf *pf = vsi->back; char *p = (char *)data; - int i; + unsigned int i; switch (stringset) { case ETH_SS_TEST: -- 2.8.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] net: i10e: use matching format indentifiers 2016-07-31 9:39 [PATCH 1/1] net: i10e: use matching format indentifiers Heinrich Schuchardt @ 2016-08-01 3:47 ` David Miller 2016-08-02 18:15 ` [PATCH 1/1 v2] " Heinrich Schuchardt 0 siblings, 1 reply; 5+ messages in thread From: David Miller @ 2016-08-01 3:47 UTC (permalink / raw) To: xypron.glpk; +Cc: jeffrey.t.kirsher, intel-wired-lan, netdev, linux-kernel From: Heinrich Schuchardt <xypron.glpk@gmx.de> Date: Sun, 31 Jul 2016 11:39:28 +0200 > i is defined as int but output as %u several times. > Change the definition to unsigned. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> I hate changes like this. The canonical way to loop over a value is to use a signed integer, named 'i', and go: for (i = 0; i < X; i ++) 'i' can never be negative, therefore we know that this usage is safe. I'd rather you convert the "%u" to "%d". I'm very disappointed in your patches, and it is clear you are just finding the easiest and simplest way to shut up compiler warnings you are seeing rather than analyzing the code you are making changes to in order to determine what the best and most appropriate fix might be. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1 v2] net: i10e: use matching format indentifiers 2016-08-01 3:47 ` David Miller @ 2016-08-02 18:15 ` Heinrich Schuchardt 2016-08-10 17:50 ` Jeff Kirsher 0 siblings, 1 reply; 5+ messages in thread From: Heinrich Schuchardt @ 2016-08-02 18:15 UTC (permalink / raw) To: David Miller Cc: Jeff Kirsher, intel-wired-lan, netdev, linux-kernel, Heinrich Schuchardt i is defined as int but output as %u several times. Adjust the format identifiers. v2: Keep definition of i as int. David indicated that this is the preferable way to define loop variables. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index c912e04..94ac712 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -1560,13 +1560,13 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset, } #endif for (i = 0; i < vsi->num_queue_pairs; i++) { - snprintf(p, ETH_GSTRING_LEN, "tx-%u.tx_packets", i); + snprintf(p, ETH_GSTRING_LEN, "tx-%d.tx_packets", i); p += ETH_GSTRING_LEN; - snprintf(p, ETH_GSTRING_LEN, "tx-%u.tx_bytes", i); + snprintf(p, ETH_GSTRING_LEN, "tx-%d.tx_bytes", i); p += ETH_GSTRING_LEN; - snprintf(p, ETH_GSTRING_LEN, "rx-%u.rx_packets", i); + snprintf(p, ETH_GSTRING_LEN, "rx-%d.rx_packets", i); p += ETH_GSTRING_LEN; - snprintf(p, ETH_GSTRING_LEN, "rx-%u.rx_bytes", i); + snprintf(p, ETH_GSTRING_LEN, "rx-%d.rx_bytes", i); p += ETH_GSTRING_LEN; } if (vsi != pf->vsi[pf->lan_vsi] || pf->hw.partition_id != 1) @@ -1581,16 +1581,16 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset, } for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) { snprintf(p, ETH_GSTRING_LEN, - "veb.tc_%u_tx_packets", i); + "veb.tc_%d_tx_packets", i); p += ETH_GSTRING_LEN; snprintf(p, ETH_GSTRING_LEN, - "veb.tc_%u_tx_bytes", i); + "veb.tc_%d_tx_bytes", i); p += ETH_GSTRING_LEN; snprintf(p, ETH_GSTRING_LEN, - "veb.tc_%u_rx_packets", i); + "veb.tc_%d_rx_packets", i); p += ETH_GSTRING_LEN; snprintf(p, ETH_GSTRING_LEN, - "veb.tc_%u_rx_bytes", i); + "veb.tc_%d_rx_bytes", i); p += ETH_GSTRING_LEN; } } @@ -1601,23 +1601,23 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset, } for (i = 0; i < I40E_MAX_USER_PRIORITY; i++) { snprintf(p, ETH_GSTRING_LEN, - "port.tx_priority_%u_xon", i); + "port.tx_priority_%d_xon", i); p += ETH_GSTRING_LEN; snprintf(p, ETH_GSTRING_LEN, - "port.tx_priority_%u_xoff", i); + "port.tx_priority_%d_xoff", i); p += ETH_GSTRING_LEN; } for (i = 0; i < I40E_MAX_USER_PRIORITY; i++) { snprintf(p, ETH_GSTRING_LEN, - "port.rx_priority_%u_xon", i); + "port.rx_priority_%d_xon", i); p += ETH_GSTRING_LEN; snprintf(p, ETH_GSTRING_LEN, - "port.rx_priority_%u_xoff", i); + "port.rx_priority_%d_xoff", i); p += ETH_GSTRING_LEN; } for (i = 0; i < I40E_MAX_USER_PRIORITY; i++) { snprintf(p, ETH_GSTRING_LEN, - "port.rx_priority_%u_xon_2_xoff", i); + "port.rx_priority_%d_xon_2_xoff", i); p += ETH_GSTRING_LEN; } /* BUG_ON(p - data != I40E_STATS_LEN * ETH_GSTRING_LEN); */ -- 2.1.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1 v2] net: i10e: use matching format indentifiers 2016-08-02 18:15 ` [PATCH 1/1 v2] " Heinrich Schuchardt @ 2016-08-10 17:50 ` Jeff Kirsher 2016-08-10 23:07 ` [PATCH 1/1 v3] net: i40e: use matching format identifiers Heinrich Schuchardt 0 siblings, 1 reply; 5+ messages in thread From: Jeff Kirsher @ 2016-08-10 17:50 UTC (permalink / raw) To: Heinrich Schuchardt, David Miller; +Cc: intel-wired-lan, netdev, linux-kernel [-- Attachment #1: Type: text/plain, Size: 618 bytes --] On Tue, 2016-08-02 at 20:15 +0200, Heinrich Schuchardt wrote: > i is defined as int but output as %u several times. > Adjust the format identifiers. > > v2: > Keep definition of i as int. > David indicated that this is the preferable way to define > loop variables. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 26 +++++++++++++------- > ------ > 1 file changed, 13 insertions(+), 13 deletions(-) your title needs fixing as well... s/i10e/i40e/ and s/indentifiers/identifiers/ [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1 v3] net: i40e: use matching format identifiers 2016-08-10 17:50 ` Jeff Kirsher @ 2016-08-10 23:07 ` Heinrich Schuchardt 0 siblings, 0 replies; 5+ messages in thread From: Heinrich Schuchardt @ 2016-08-10 23:07 UTC (permalink / raw) To: Jeff Kirsher Cc: Jesse Brandeburg, Shannon Nelson, Carolyn Wyborny, Don Skidmore, Bruce Allan, John Ronciak, Mitch Williams, intel-wired-lan, David Miller, netdev, linux-kernel, Heinrich Schuchardt i is defined as int but output as %u several times. Adjust the format identifiers. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- v3: fix typos in title, old title: net: i10e: use matching format indentifiers v2: Keep definition of i as int. drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index c912e04..94ac712 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -1560,13 +1560,13 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset, } #endif for (i = 0; i < vsi->num_queue_pairs; i++) { - snprintf(p, ETH_GSTRING_LEN, "tx-%u.tx_packets", i); + snprintf(p, ETH_GSTRING_LEN, "tx-%d.tx_packets", i); p += ETH_GSTRING_LEN; - snprintf(p, ETH_GSTRING_LEN, "tx-%u.tx_bytes", i); + snprintf(p, ETH_GSTRING_LEN, "tx-%d.tx_bytes", i); p += ETH_GSTRING_LEN; - snprintf(p, ETH_GSTRING_LEN, "rx-%u.rx_packets", i); + snprintf(p, ETH_GSTRING_LEN, "rx-%d.rx_packets", i); p += ETH_GSTRING_LEN; - snprintf(p, ETH_GSTRING_LEN, "rx-%u.rx_bytes", i); + snprintf(p, ETH_GSTRING_LEN, "rx-%d.rx_bytes", i); p += ETH_GSTRING_LEN; } if (vsi != pf->vsi[pf->lan_vsi] || pf->hw.partition_id != 1) @@ -1581,16 +1581,16 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset, } for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) { snprintf(p, ETH_GSTRING_LEN, - "veb.tc_%u_tx_packets", i); + "veb.tc_%d_tx_packets", i); p += ETH_GSTRING_LEN; snprintf(p, ETH_GSTRING_LEN, - "veb.tc_%u_tx_bytes", i); + "veb.tc_%d_tx_bytes", i); p += ETH_GSTRING_LEN; snprintf(p, ETH_GSTRING_LEN, - "veb.tc_%u_rx_packets", i); + "veb.tc_%d_rx_packets", i); p += ETH_GSTRING_LEN; snprintf(p, ETH_GSTRING_LEN, - "veb.tc_%u_rx_bytes", i); + "veb.tc_%d_rx_bytes", i); p += ETH_GSTRING_LEN; } } @@ -1601,23 +1601,23 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset, } for (i = 0; i < I40E_MAX_USER_PRIORITY; i++) { snprintf(p, ETH_GSTRING_LEN, - "port.tx_priority_%u_xon", i); + "port.tx_priority_%d_xon", i); p += ETH_GSTRING_LEN; snprintf(p, ETH_GSTRING_LEN, - "port.tx_priority_%u_xoff", i); + "port.tx_priority_%d_xoff", i); p += ETH_GSTRING_LEN; } for (i = 0; i < I40E_MAX_USER_PRIORITY; i++) { snprintf(p, ETH_GSTRING_LEN, - "port.rx_priority_%u_xon", i); + "port.rx_priority_%d_xon", i); p += ETH_GSTRING_LEN; snprintf(p, ETH_GSTRING_LEN, - "port.rx_priority_%u_xoff", i); + "port.rx_priority_%d_xoff", i); p += ETH_GSTRING_LEN; } for (i = 0; i < I40E_MAX_USER_PRIORITY; i++) { snprintf(p, ETH_GSTRING_LEN, - "port.rx_priority_%u_xon_2_xoff", i); + "port.rx_priority_%d_xon_2_xoff", i); p += ETH_GSTRING_LEN; } /* BUG_ON(p - data != I40E_STATS_LEN * ETH_GSTRING_LEN); */ -- 2.1.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-10 23:07 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-07-31 9:39 [PATCH 1/1] net: i10e: use matching format indentifiers Heinrich Schuchardt 2016-08-01 3:47 ` David Miller 2016-08-02 18:15 ` [PATCH 1/1 v2] " Heinrich Schuchardt 2016-08-10 17:50 ` Jeff Kirsher 2016-08-10 23:07 ` [PATCH 1/1 v3] net: i40e: use matching format identifiers Heinrich Schuchardt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).