From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH v2 0/3] Make /proc per net namespace objects belong to container
Date: Wed, 10 Aug 2016 14:35:59 -0700 [thread overview]
Message-ID: <1470864962-25056-1-git-send-email-dmitry.torokhov@gmail.com> (raw)
Currently [almost] all /proc objects belong to the global root, even if
data belongs to a given namespace within a container and (at least for
sysctls) we work around permssions checks to allow container's root to
access the data.
This series changes ownership of net namespace /proc objects
(/proc/net/self/* and /proc/sys/net/*) to be container's root and not
global root when there exists mapping for container's root in user
namespace.
This helps when running Android CTS in a container, but I think it makes
sense regardless.
Changes from V1:
- added fix for crash when !CONFIG_NET_NS (new patch #1)
- addressed Eric'c comments for error handling style in patch #3 and
added his Ack
- adjusted patch #2 to use the same style of erro handling
- sent out as series instead of separate patches
Dmitry Torokhov (3):
netns: do not call pernet ops for not yet set up init_net namespace
proc: make proc entries inherit ownership from parent
net: make net namespace sysctls belong to container's owner
fs/proc/generic.c | 2 ++
fs/proc/proc_net.c | 13 +++++++++++++
fs/proc/proc_sysctl.c | 5 +++++
include/linux/sysctl.h | 4 ++++
net/core/net_namespace.c | 21 +++++++++++++++++----
net/sysctl_net.c | 29 ++++++++++++++++++++---------
6 files changed, 61 insertions(+), 13 deletions(-)
--
2.8.0.rc3.226.g39d4020
next reply other threads:[~2016-08-10 21:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 21:35 Dmitry Torokhov [this message]
2016-08-10 21:36 ` [PATCH v2 1/3] netns: do not call pernet ops for not yet set up init_net namespace Dmitry Torokhov
2016-08-10 21:36 ` [PATCH v2 2/3] proc: make proc entries inherit ownership from parent Dmitry Torokhov
2016-08-10 21:36 ` [PATCH v2 3/3] net: make net namespace sysctls belong to container's owner Dmitry Torokhov
2016-09-29 15:46 ` Dmitry Torokhov
2016-09-30 5:21 ` David Miller
2016-09-30 22:26 ` Dmitry Torokhov
2016-08-15 4:09 ` [PATCH v2 0/3] Make /proc per net namespace objects belong to container David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470864962-25056-1-git-send-email-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).