From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: [Patch net v3 2/5] net_sched: remove an unnecessary list_del()
Date: Thu, 11 Aug 2016 17:41:40 -0700 [thread overview]
Message-ID: <1470962503-19682-3-git-send-email-xiyou.wangcong@gmail.com> (raw)
In-Reply-To: <1470962503-19682-1-git-send-email-xiyou.wangcong@gmail.com>
This list_del() for tc action is not needed actually,
because we only use this list to chain bulk operations,
therefore should not be carried for latter operations.
Fixes: ec0595cc4495 ("net_sched: get rid of struct tcf_common")
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
net/sched/act_api.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index cce6986..b4c7be3 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -64,7 +64,6 @@ int __tcf_hash_release(struct tc_action *p, bool bind, bool strict)
if (p->tcfa_bindcnt <= 0 && p->tcfa_refcnt <= 0) {
if (p->ops->cleanup)
p->ops->cleanup(p, bind);
- list_del(&p->list);
tcf_hash_destroy(p->hinfo, p);
ret = ACT_P_DELETED;
}
--
1.8.4.5
next prev parent reply other threads:[~2016-08-12 0:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 0:41 [Patch net v3 0/5] net_sched: tc action fixes and updates Cong Wang
2016-08-12 0:41 ` [Patch net v3 1/5] net_sched: remove the leftover cleanup_a() Cong Wang
2016-08-12 0:41 ` Cong Wang [this message]
2016-08-12 0:41 ` [Patch net v3 3/5] net_sched: fix a typo in tc_for_each_action() Cong Wang
2016-08-12 0:41 ` [Patch net v3 4/5] net_sched: move tc offload macros to pkt_cls.h Cong Wang
2016-08-12 0:41 ` [Patch net v3 5/5] net_sched: convert tcf_exts from list to pointer array Cong Wang
2016-08-13 11:33 ` Jamal Hadi Salim
2016-08-14 5:03 ` Cong Wang
2016-08-14 11:00 ` Jamal Hadi Salim
2016-08-16 12:54 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470962503-19682-3-git-send-email-xiyou.wangcong@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).