* [PATCH -next] net: macb: add missing free_netdev() on error in macb_probe()
@ 2016-08-12 15:43 Wei Yongjun
2016-08-15 4:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-08-12 15:43 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: Wei Yongjun, netdev
Add the missing free_netdev() before return from function macb_probe()
in the platform_get_irq() error handling case.
Fixes: c69618b3e4f2 ("net/macb: fix probe sequence to setup clocks earlier")
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 6b797e3..dbce938 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -2985,7 +2985,7 @@ static int macb_probe(struct platform_device *pdev)
dev->irq = platform_get_irq(pdev, 0);
if (dev->irq < 0) {
err = dev->irq;
- goto err_disable_clocks;
+ goto err_out_free_netdev;
}
mac = of_get_mac_address(np);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: macb: add missing free_netdev() on error in macb_probe()
2016-08-12 15:43 [PATCH -next] net: macb: add missing free_netdev() on error in macb_probe() Wei Yongjun
@ 2016-08-15 4:24 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-08-15 4:24 UTC (permalink / raw)
To: weiyj.lk; +Cc: nicolas.ferre, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Fri, 12 Aug 2016 15:43:54 +0000
> Add the missing free_netdev() before return from function macb_probe()
> in the platform_get_irq() error handling case.
>
> Fixes: c69618b3e4f2 ("net/macb: fix probe sequence to setup clocks earlier")
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-15 4:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-12 15:43 [PATCH -next] net: macb: add missing free_netdev() on error in macb_probe() Wei Yongjun
2016-08-15 4:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).